From patchwork Fri Mar 2 09:52:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 144182 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 0504810088E for ; Fri, 2 Mar 2012 20:52:32 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1S3PA6-0006Z7-Qm for incoming@patchwork.ozlabs.org; Fri, 02 Mar 2012 09:52:30 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1S3PA5-0006Yl-Ad for fwts-devel@lists.ubuntu.com; Fri, 02 Mar 2012 09:52:29 +0000 Received: from cpc19-craw6-2-0-cust5.croy.cable.virginmedia.com ([77.102.228.6] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1S3PA5-00052w-8E for fwts-devel@lists.ubuntu.com; Fri, 02 Mar 2012 09:52:29 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH 1/2] bios: hdaaudio: use calloc() instead of malloc() Date: Fri, 2 Mar 2012 09:52:26 +0000 Message-Id: <1330681947-17406-2-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.9 In-Reply-To: <1330681947-17406-1-git-send-email-colin.king@canonical.com> References: <1330681947-17406-1-git-send-email-colin.king@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Alex Hung --- src/bios/hdaaudio/hdaaudio.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/bios/hdaaudio/hdaaudio.c b/src/bios/hdaaudio/hdaaudio.c index b49f202..7dc1823 100644 --- a/src/bios/hdaaudio/hdaaudio.c +++ b/src/bios/hdaaudio/hdaaudio.c @@ -43,7 +43,8 @@ static int hda_audio_read_pins(fwts_framework *fw, const char *path, return FWTS_ERROR; while (fscanf(fp, "0x%hx 0x%x\n", &pin, &setting) == 2) { - if ((pin_setting = malloc(sizeof(hda_audio_pin_setting))) == NULL) { + pin_setting = calloc(1, sizeof(hda_audio_pin_setting)); + if (pin_setting == NULL) { fwts_list_free(settings, free); fclose(fp); return FWTS_ERROR;