Patchwork bios: ebdadump: ensure source fits into 80 columns

login
register
mail settings
Submitter Colin King
Date March 2, 2012, 9:45 a.m.
Message ID <1330681537-16945-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/144177/
State Accepted
Headers show

Comments

Colin King - March 2, 2012, 9:45 a.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/bios/ebdadump/ebdadump.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
Keng-Yu Lin - March 5, 2012, 8:07 a.m.
On Fri, Mar 2, 2012 at 5:45 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/bios/ebdadump/ebdadump.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/bios/ebdadump/ebdadump.c b/src/bios/ebdadump/ebdadump.c
> index 1cfca3d..7d16d9a 100644
> --- a/src/bios/ebdadump/ebdadump.c
> +++ b/src/bios/ebdadump/ebdadump.c
> @@ -30,7 +30,7 @@ static void ebdadump_data(fwts_framework *fw,
>        int i;
>
>        for (i=0; i<length; i+=16) {
> -               fwts_dump_raw_data(buffer, sizeof(buffer), data+i, offset+i, 16);
> +               fwts_dump_raw_data(buffer, sizeof buffer, data+i, offset+i, 16);
>                fwts_log_info_verbatum(fw, "%s", buffer);
>        }
>  }
> @@ -49,7 +49,8 @@ static int ebdadump_test1(fwts_framework *fw)
>        len = BIOS_ROM_START - ebda_addr;
>
>        if (ebda_addr > BIOS_ROM_START) {
> -               fwts_log_error(fw, "EBDA start address is greater than the BIOS ROM start address.");
> +               fwts_log_error(fw, "EBDA start address is greater than the "
> +                       "BIOS ROM start address.");
>                return FWTS_ERROR;
>        }
>
> @@ -81,6 +82,7 @@ static fwts_framework_ops ebdadump_ops = {
>        .minor_tests = ebdadump_tests
>  };
>
> -FWTS_REGISTER(ebdadump, &ebdadump_ops, FWTS_TEST_ANYTIME, FWTS_UTILS | FWTS_ROOT_PRIV);
> +FWTS_REGISTER(ebdadump, &ebdadump_ops, FWTS_TEST_ANYTIME,
> +       FWTS_UTILS | FWTS_ROOT_PRIV);
>
>  #endif
> --
> 1.7.9
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - March 7, 2012, 3:19 a.m.
On 03/02/2012 05:45 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/bios/ebdadump/ebdadump.c |    8 +++++---
>   1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/src/bios/ebdadump/ebdadump.c b/src/bios/ebdadump/ebdadump.c
> index 1cfca3d..7d16d9a 100644
> --- a/src/bios/ebdadump/ebdadump.c
> +++ b/src/bios/ebdadump/ebdadump.c
> @@ -30,7 +30,7 @@ static void ebdadump_data(fwts_framework *fw,
>   	int i;
>
>   	for (i=0; i<length; i+=16) {
> -		fwts_dump_raw_data(buffer, sizeof(buffer), data+i, offset+i, 16);
> +		fwts_dump_raw_data(buffer, sizeof buffer, data+i, offset+i, 16);
>   		fwts_log_info_verbatum(fw, "%s", buffer);
>   	}
>   }
> @@ -49,7 +49,8 @@ static int ebdadump_test1(fwts_framework *fw)
>   	len = BIOS_ROM_START - ebda_addr;
>
>   	if (ebda_addr>  BIOS_ROM_START) {
> -		fwts_log_error(fw, "EBDA start address is greater than the BIOS ROM start address.");
> +		fwts_log_error(fw, "EBDA start address is greater than the "
> +			"BIOS ROM start address.");
>   		return FWTS_ERROR;
>   	}
>
> @@ -81,6 +82,7 @@ static fwts_framework_ops ebdadump_ops = {
>   	.minor_tests = ebdadump_tests
>   };
>
> -FWTS_REGISTER(ebdadump,&ebdadump_ops, FWTS_TEST_ANYTIME, FWTS_UTILS | FWTS_ROOT_PRIV);
> +FWTS_REGISTER(ebdadump,&ebdadump_ops, FWTS_TEST_ANYTIME,
> +	FWTS_UTILS | FWTS_ROOT_PRIV);
>
>   #endif
Acked-by Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/src/bios/ebdadump/ebdadump.c b/src/bios/ebdadump/ebdadump.c
index 1cfca3d..7d16d9a 100644
--- a/src/bios/ebdadump/ebdadump.c
+++ b/src/bios/ebdadump/ebdadump.c
@@ -30,7 +30,7 @@  static void ebdadump_data(fwts_framework *fw,
 	int i;
 
 	for (i=0; i<length; i+=16) {
-		fwts_dump_raw_data(buffer, sizeof(buffer), data+i, offset+i, 16);
+		fwts_dump_raw_data(buffer, sizeof buffer, data+i, offset+i, 16);
 		fwts_log_info_verbatum(fw, "%s", buffer);
 	}
 }
@@ -49,7 +49,8 @@  static int ebdadump_test1(fwts_framework *fw)
 	len = BIOS_ROM_START - ebda_addr;
 
 	if (ebda_addr > BIOS_ROM_START) {
-		fwts_log_error(fw, "EBDA start address is greater than the BIOS ROM start address.");
+		fwts_log_error(fw, "EBDA start address is greater than the "
+			"BIOS ROM start address.");
 		return FWTS_ERROR;
 	}
 
@@ -81,6 +82,7 @@  static fwts_framework_ops ebdadump_ops = {
 	.minor_tests = ebdadump_tests
 };
 
-FWTS_REGISTER(ebdadump, &ebdadump_ops, FWTS_TEST_ANYTIME, FWTS_UTILS | FWTS_ROOT_PRIV);
+FWTS_REGISTER(ebdadump, &ebdadump_ops, FWTS_TEST_ANYTIME,
+	FWTS_UTILS | FWTS_ROOT_PRIV);
 
 #endif