Patchwork [2/3] acpi: wmi: const func args

login
register
mail settings
Submitter Colin King
Date March 2, 2012, 9:10 a.m.
Message ID <1330679404-8789-3-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/144158/
State Accepted
Headers show

Comments

Colin King - March 2, 2012, 9:10 a.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/wmi/wmi.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Keng-Yu Lin - March 5, 2012, 7:54 a.m.
On Fri, Mar 2, 2012 at 5:10 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/wmi/wmi.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/acpi/wmi/wmi.c b/src/acpi/wmi/wmi.c
> index c7e3b15..8190e17 100644
> --- a/src/acpi/wmi/wmi.c
> +++ b/src/acpi/wmi/wmi.c
> @@ -112,7 +112,7 @@ static char *wmi_wdg_flags_to_text(const fwts_wmi_flags flags)
>  }
>
>  static void wmi_parse_wdg_data(fwts_framework *fw,
> -       int size, uint8_t *wdg_data, bool *result)
> +       const int size, const uint8_t *wdg_data, bool *result)
>  {
>        int i;
>        int advice_given = 0;
> @@ -191,7 +191,7 @@ static void wmi_parse_wdg_data(fwts_framework *fw,
>  }
>
>  static void wmi_get_wdg_data(fwts_framework *fw,
> -       fwts_list_link *item, int size, uint8_t *wdg_data)
> +       fwts_list_link *item, const int size, uint8_t *wdg_data)
>  {
>        char *str;
>        uint8_t *data = wdg_data;
> @@ -300,7 +300,7 @@ static void wmi_parse_for_wdg(fwts_framework *fw,
>  }
>
>  static int wmi_table(fwts_framework *fw,
> -       char *table, int which, char *name, bool *result)
> +       const char *table, const int which, const char *name, bool *result)
>  {
>        fwts_list_link *item;
>        fwts_list* iasl_output;
> --
> 1.7.9
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - March 8, 2012, 9:46 a.m.
On 03/02/2012 05:10 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/acpi/wmi/wmi.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/acpi/wmi/wmi.c b/src/acpi/wmi/wmi.c
> index c7e3b15..8190e17 100644
> --- a/src/acpi/wmi/wmi.c
> +++ b/src/acpi/wmi/wmi.c
> @@ -112,7 +112,7 @@ static char *wmi_wdg_flags_to_text(const fwts_wmi_flags flags)
>   }
>
>   static void wmi_parse_wdg_data(fwts_framework *fw,
> -	int size, uint8_t *wdg_data, bool *result)
> +	const int size, const uint8_t *wdg_data, bool *result)
>   {
>   	int i;
>   	int advice_given = 0;
> @@ -191,7 +191,7 @@ static void wmi_parse_wdg_data(fwts_framework *fw,
>   }
>
>   static void wmi_get_wdg_data(fwts_framework *fw,
> -	fwts_list_link *item, int size, uint8_t *wdg_data)
> +	fwts_list_link *item, const int size, uint8_t *wdg_data)
>   {
>   	char *str;
>   	uint8_t *data = wdg_data;
> @@ -300,7 +300,7 @@ static void wmi_parse_for_wdg(fwts_framework *fw,
>   }
>
>   static int wmi_table(fwts_framework *fw,
> -	char *table, int which, char *name, bool *result)
> +	const char *table, const int which, const char *name, bool *result)
>   {
>   	fwts_list_link *item;
>   	fwts_list* iasl_output;
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/src/acpi/wmi/wmi.c b/src/acpi/wmi/wmi.c
index c7e3b15..8190e17 100644
--- a/src/acpi/wmi/wmi.c
+++ b/src/acpi/wmi/wmi.c
@@ -112,7 +112,7 @@  static char *wmi_wdg_flags_to_text(const fwts_wmi_flags flags)
 }
 
 static void wmi_parse_wdg_data(fwts_framework *fw,
-	int size, uint8_t *wdg_data, bool *result)
+	const int size, const uint8_t *wdg_data, bool *result)
 {
 	int i;
 	int advice_given = 0;
@@ -191,7 +191,7 @@  static void wmi_parse_wdg_data(fwts_framework *fw,
 }
 
 static void wmi_get_wdg_data(fwts_framework *fw,
-	fwts_list_link *item, int size, uint8_t *wdg_data)
+	fwts_list_link *item, const int size, uint8_t *wdg_data)
 {
 	char *str;
 	uint8_t *data = wdg_data;
@@ -300,7 +300,7 @@  static void wmi_parse_for_wdg(fwts_framework *fw,
 }
 
 static int wmi_table(fwts_framework *fw,
-	char *table, int which, char *name, bool *result)
+	const char *table, const int which, const char *name, bool *result)
 {
 	fwts_list_link *item;
 	fwts_list* iasl_output;