Patchwork [U-Boot,2/3] ventana: define CONFIG_MACH_VENTANA

login
register
mail settings
Submitter Troy Kisky
Date March 1, 2012, 9:13 p.m.
Message ID <1330636394-25173-2-git-send-email-troy.kisky@boundarydevices.com>
Download mbox | patch
Permalink /patch/144132/
State Rejected
Headers show

Comments

Troy Kisky - March 1, 2012, 9:13 p.m.
ventana uses board/nvidia/seaboard/seaboard.c
which uses machine_is_ventana.

Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
---
 include/configs/ventana.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Stephen Warren - March 1, 2012, 9:30 p.m.
On 03/01/2012 02:13 PM, Troy Kisky wrote:
> ventana uses board/nvidia/seaboard/seaboard.c
> which uses machine_is_ventana.

> diff --git a/include/configs/ventana.h b/include/configs/ventana.h

> +#define CONFIG_MACH_VENTANA

It'd be nice not to have to do this; that header already does:

#define CONFIG_MACH_TYPE                MACH_TYPE_VENTANA

Can't the code key off that? Otherwise, any use of machine_is_xxx() will
be very error-prone, since CONFIG_MACH_XXX has to be manually defined,
and people will forget.

Patch

diff --git a/include/configs/ventana.h b/include/configs/ventana.h
index acc9b43..b5caebb 100644
--- a/include/configs/ventana.h
+++ b/include/configs/ventana.h
@@ -24,6 +24,8 @@ 
 #ifndef __CONFIG_H
 #define __CONFIG_H
 
+#define CONFIG_MACH_VENTANA
+
 #include <asm/sizes.h>
 #include "tegra2-common.h"