Patchwork [5/7] lantiq_etop: use dev_set_mac_address() instead of ltq_etop_set_mac_address()

login
register
mail settings
Submitter Danny Kukawka
Date March 1, 2012, 4:52 p.m.
Message ID <1330620747-4047-6-git-send-email-danny.kukawka@bisect.de>
Download mbox | patch
Permalink /patch/144074/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Danny Kukawka - March 1, 2012, 4:52 p.m.
Use dev_set_mac_address() instead of ltq_etop_set_mac_address() directly
to get validation checks for free.

Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
---
 drivers/net/ethernet/lantiq_etop.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
John Crispin - March 2, 2012, 1:53 p.m.
On 01/03/12 17:52, Danny Kukawka wrote:
> Use dev_set_mac_address() instead of ltq_etop_set_mac_address() directly
> to get validation checks for free.
>
> Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
Acked-by: John Crispin <blogic@openwrt.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 5dc9cbd..2419f51 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -650,11 +650,11 @@  ltq_etop_init(struct net_device *dev)
 		random_mac = true;
 	}
 
-	err = ltq_etop_set_mac_address(dev, &mac);
+	err = dev_set_mac_address(dev, &mac);
 	if (err)
 		goto err_netdev;
 
-	/* Set addr_assign_type here, ltq_etop_set_mac_address would reset it. */
+	/* Set addr_assign_type here, dev_set_mac_address would reset it. */
 	if (random_mac)
 		dev->addr_assign_type |= NET_ADDR_RANDOM;