Patchwork usb: Fix signature of stub usb_host_device_open

login
register
mail settings
Submitter Jan Kiszka
Date March 1, 2012, 9:43 a.m.
Message ID <4F4F44D6.2020907@siemens.com>
Download mbox | patch
Permalink /patch/143973/
State New
Headers show

Comments

Jan Kiszka - March 1, 2012, 9:43 a.m.
This was a breakage of 3741715cf2.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 usb-stub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Gerd Hoffmann - March 1, 2012, 10:50 a.m.
On 03/01/12 10:43, Jan Kiszka wrote:
> -USBDevice *usb_host_device_open(const char *devname)
> +USBDevice *usb_host_device_open(USBBus *bus, const char *devname)

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
  Gerd
Blue Swirl - March 3, 2012, 5:56 p.m.
Thanks, applied.

On Thu, Mar 1, 2012 at 09:43, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> This was a breakage of 3741715cf2.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  usb-stub.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/usb-stub.c b/usb-stub.c
> index 9c3fcea..b4e10c1 100644
> --- a/usb-stub.c
> +++ b/usb-stub.c
> @@ -41,7 +41,7 @@ void usb_host_info(Monitor *mon)
>  }
>
>  /* XXX: modify configure to compile the right host driver */
> -USBDevice *usb_host_device_open(const char *devname)
> +USBDevice *usb_host_device_open(USBBus *bus, const char *devname)
>  {
>     return NULL;
>  }
> --
> 1.7.3.4
>
Stefan Hajnoczi - March 5, 2012, 4:47 p.m.
On Thu, Mar 01, 2012 at 10:43:50AM +0100, Jan Kiszka wrote:
> This was a breakage of 3741715cf2.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  usb-stub.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Even if a build fix is trivial, I suggest sending it only to
qemu-devel@nongnu.org because trivial patches pull requests only get
sent out about once per week.  It's fastest to get build fixed committed
directly.

Stefan

Patch

diff --git a/usb-stub.c b/usb-stub.c
index 9c3fcea..b4e10c1 100644
--- a/usb-stub.c
+++ b/usb-stub.c
@@ -41,7 +41,7 @@  void usb_host_info(Monitor *mon)
 }
 
 /* XXX: modify configure to compile the right host driver */
-USBDevice *usb_host_device_open(const char *devname)
+USBDevice *usb_host_device_open(USBBus *bus, const char *devname)
 {
     return NULL;
 }