From patchwork Thu Mar 1 09:17:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: santosh nayak X-Patchwork-Id: 143969 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 14D0F1007D2 for ; Thu, 1 Mar 2012 20:24:57 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965336Ab2CAJYi (ORCPT ); Thu, 1 Mar 2012 04:24:38 -0500 Received: from mail-pw0-f46.google.com ([209.85.160.46]:49532 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964878Ab2CAJYf (ORCPT ); Thu, 1 Mar 2012 04:24:35 -0500 Received: by mail-pw0-f46.google.com with SMTP id up15so667120pbc.19 for ; Thu, 01 Mar 2012 01:24:35 -0800 (PST) Received-SPF: pass (google.com: domain of santoshprasadnayak@gmail.com designates 10.68.197.35 as permitted sender) client-ip=10.68.197.35; Authentication-Results: mr.google.com; spf=pass (google.com: domain of santoshprasadnayak@gmail.com designates 10.68.197.35 as permitted sender) smtp.mail=santoshprasadnayak@gmail.com; dkim=pass header.i=santoshprasadnayak@gmail.com Received: from mr.google.com ([10.68.197.35]) by 10.68.197.35 with SMTP id ir3mr98422pbc.84.1330593875245 (num_hops = 1); Thu, 01 Mar 2012 01:24:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=o2I1bU88CfKQ2XLXoH5sbrxZN9tD3nHk3LZ+1JsJFVw=; b=mU6tZuE7soA7pUakweT20GAuHiZS9xKqsvPAxUUSZcodXFyFWUNGxEO+H6Lo/GBF6d KyE/SklUNwl5vV6XESykAqLx603oNc+m6V7DgPBlGMcaWTFPsXt7o9jLsP4VX7nLhMCJ dFAUzl+kACZY+q1gVdhVIkNEuV0Is4PWYp3QI= Received: by 10.68.197.35 with SMTP id ir3mr29147pbc.84.1330593480814; Thu, 01 Mar 2012 01:18:00 -0800 (PST) Received: from localhost.localdomain ([64.103.156.75]) by mx.google.com with ESMTPS id g4sm1607790pbs.17.2012.03.01.01.17.56 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 01 Mar 2012 01:18:00 -0800 (PST) From: santosh nayak To: bart.de.schuymer@pandora.be Cc: pablo@netfilter.org, kaber@trash.net, shemminger@vyatta.com, davem@davemloft.net, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Santosh Nayak Subject: [PATCH 2/3] netfilter: potential null derefence. Date: Thu, 1 Mar 2012 14:47:14 +0530 Message-Id: <1330593434-19275-1-git-send-email-santoshprasadnayak@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Santosh Nayak I am getting following error. " net/bridge/netfilter/ebtables.c:269 ebt_do_table() error: potential null derefence 'cs'" i = cs[sp].n; // If cs == Null then this will cause problem. Signed-off-by: Santosh Nayak --- net/bridge/netfilter/ebtables.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c index f3fcbd9..9c0f177 100644 --- a/net/bridge/netfilter/ebtables.c +++ b/net/bridge/netfilter/ebtables.c @@ -209,8 +209,10 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb, smp_processor_id()); if (private->chainstack) cs = private->chainstack[smp_processor_id()]; - else + else { cs = NULL; + goto out; + } chaininfo = private->hook_entry[hook]; nentries = private->hook_entry[hook]->nentries; point = (struct ebt_entry *)(private->hook_entry[hook]->data); @@ -313,6 +315,7 @@ letscontinue: read_unlock_bh(&table->lock); return NF_ACCEPT; } +out: read_unlock_bh(&table->lock); return NF_DROP; }