Patchwork davinci_emac: fixed setting MAC at init time

login
register
mail settings
Submitter Bas van den Berg
Date March 1, 2012, 8:42 a.m.
Message ID <20120301084239.GA17146@altenpts-laptop>
Download mbox | patch
Permalink /patch/143954/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Bas van den Berg - March 1, 2012, 8:42 a.m.
Without this patch, the MAC number will show up as zero's until the interface
is brought up for the first time. (eg. with ifconfig -a)

Signed-off-by: Bas van den Berg <b.van.den.berg.nl@gmail.com>
---
 drivers/net/ethernet/ti/davinci_emac.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
David Miller - March 1, 2012, 9:28 p.m.
From: Bas van den Berg <b.van.den.berg.nl@gmail.com>
Date: Thu, 1 Mar 2012 09:42:42 +0100

> Without this patch, the MAC number will show up as zero's until the interface
> is brought up for the first time. (eg. with ifconfig -a)
> 
> Signed-off-by: Bas van den Berg <b.van.den.berg.nl@gmail.com>

Well then the copy (which is also unnecessarily by hand using a loop
instead of a memcpy call) in emac_dev_open() is redundant and should
be removed when you make this change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
index 4b2f545..11b169a 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -1904,6 +1904,7 @@  static int __devinit davinci_emac_probe(struct platform_device *pdev)
 		dev_warn(&pdev->dev, "using random MAC addr: %pM\n",
 							priv->mac_addr);
 	}
+	memcpy(ndev->dev_addr, priv->mac_addr, ndev->addr_len);
 
 	ndev->netdev_ops = &emac_netdev_ops;
 	SET_ETHTOOL_OPS(ndev, &ethtool_ops);