Patchwork pc: make user-triggerable exit conditional to DEBUG_BIOS define

login
register
mail settings
Submitter Hervé Poussineau
Date Feb. 29, 2012, 10:44 p.m.
Message ID <1330555499-11726-1-git-send-email-hpoussin@reactos.org>
Download mbox | patch
Permalink /patch/143828/
State New
Headers show

Comments

Hervé Poussineau - Feb. 29, 2012, 10:44 p.m.
The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/pc.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Anthony Liguori - March 1, 2012, 1:55 a.m.
On 02/29/2012 04:44 PM, Hervé Poussineau wrote:
> The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.

For what?  What device would normally be there?

I don't want to disable this by default.  My regression suite depends on this as 
an exit mechanism.

Regards,

Anthony Liguori

>
> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
> ---
>   hw/pc.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 12c02f2..113a38a 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
>           /* LGPL'ed VGA BIOS messages */
>       case 0x501:
>       case 0x502:
> +#ifdef DEBUG_BIOS
>           exit((val<<  1) | 1);
> +#endif
> +        break;
>       case 0x500:
>       case 0x503:
>   #ifdef DEBUG_BIOS
Hervé Poussineau - March 1, 2012, 6:42 a.m.
Hi,

I've no idea what installer is trying to do with this port, or what 
device it is probing.

We can maybe add a runtime switch to exit Qemu or not. What do you think 
of '-vgabios-backdoor' which, if specified, does the exit ?

Otherwise, which solution do you propose?

Regards,

Hervé

Anthony Liguori a écrit :
> On 02/29/2012 04:44 PM, Hervé Poussineau wrote:
>> The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.
> 
> For what?  What device would normally be there?
> 
> I don't want to disable this by default.  My regression suite depends on 
> this as an exit mechanism.
> 
> Regards,
> 
> Anthony Liguori
> 
>>
>> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
>> ---
>>   hw/pc.c |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/pc.c b/hw/pc.c
>> index 12c02f2..113a38a 100644
>> --- a/hw/pc.c
>> +++ b/hw/pc.c
>> @@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, 
>> uint32_t addr, uint32_t val)
>>           /* LGPL'ed VGA BIOS messages */
>>       case 0x501:
>>       case 0x502:
>> +#ifdef DEBUG_BIOS
>>           exit((val<<  1) | 1);
>> +#endif
>> +        break;
>>       case 0x500:
>>       case 0x503:
>>   #ifdef DEBUG_BIOS
> 
>

Patch

diff --git a/hw/pc.c b/hw/pc.c
index 12c02f2..113a38a 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -565,7 +565,10 @@  static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
         /* LGPL'ed VGA BIOS messages */
     case 0x501:
     case 0x502:
+#ifdef DEBUG_BIOS
         exit((val << 1) | 1);
+#endif
+        break;
     case 0x500:
     case 0x503:
 #ifdef DEBUG_BIOS