Patchwork [U-Boot,0/2] Highbank fixes for 2012.03

login
register
mail settings
Submitter Rob Herring
Date Feb. 29, 2012, 2:15 p.m.
Message ID <4F4E32E9.1060405@gmail.com>
Download mbox
Permalink /patch/143735/
State Not Applicable
Delegated to: Albert ARIBAUD
Headers show

Pull-request

git://sources.calxeda.com/u-boot.git fixes

Comments

Rob Herring - Feb. 29, 2012, 2:15 p.m.
Albert,

On 02/28/2012 04:48 PM, Albert ARIBAUD wrote:
> Hi Rob,
> 
> Le 21/02/2012 23:52, Rob Herring a écrit :
>> From: Rob Herring<rob.herring@calxeda.com>
>>
>> This is a couple of fixes for a build error and warning.
>>
>> Rob
>>
>> Rob Herring (2):
>>    ARM: highbank: fix warning for calxedaxgmac_initialize
>>    ARM: highbank: add missing get_tbclk
>>
>>   arch/arm/cpu/armv7/highbank/timer.c |    5 +++++
>>   board/highbank/highbank.c           |    1 +
>>   2 files changed, 6 insertions(+), 0 deletions(-)
> 
> Weird: I get a persistent error with ELDK42 (4.2.2) and Ubuntu (4.6.1)
> ARM toolchains:
> 
> calxedaxgmac.c:317: error: expected declaration specifiers or '...'
> before numeric constant
> calxedaxgmac.c:317: warning: function declaration isn't a prototype
> 
> I would not mention it if you did not seem to ba able to build on your
> side, so I must have something wrong in my setup. Can you tell me on
> which commit ID you applied your patch set?

You also need the previous fix that I sent:

http://patchwork.ozlabs.org/patch/139020/

Here's a pull request for all 4 fixes if you prefer:

The following changes since commit 2acca35ce4604dcef933f07d90aa9c9c930e1049:

  Merge branch 'master' of git://git.denx.de/u-boot-mmc (2012-02-17
23:54:46 +0100)

are available in the git repository at:

  git://sources.calxeda.com/u-boot.git fixes

Rob Herring (4):
      net: calxedaxgmac: fix build due to missing __aligned definition
      ARM: highbank: fix warning for calxedaxgmac_initialize
      ARM: highbank: add missing get_tbclk
      ARM: highbank: fix us_to_tick calculation

 arch/arm/cpu/armv7/highbank/timer.c |    9 +++++++--
 board/highbank/highbank.c           |    1 +
 drivers/net/calxedaxgmac.c          |    1 +
 3 files changed, 9 insertions(+), 2 deletions(-)

Thanks,
Rob