From patchwork Wed Feb 29 07:15:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Engelhardt X-Patchwork-Id: 143677 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D54ADB6FB6 for ; Wed, 29 Feb 2012 18:15:59 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030751Ab2B2HPx (ORCPT ); Wed, 29 Feb 2012 02:15:53 -0500 Received: from seven.medozas.de ([188.40.89.202]:48528 "EHLO seven.medozas.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030750Ab2B2HPv (ORCPT ); Wed, 29 Feb 2012 02:15:51 -0500 Received: by seven.medozas.de (Postfix, from userid 25121) id BC38521A0ABF; Wed, 29 Feb 2012 08:15:45 +0100 (CET) From: Jan Engelhardt To: pablo@netfilter.org Cc: netfilter-devel@vger.kernel.org Subject: [PATCH 4/6] Properly NUL-terminate name in nfct_timeout_attr_set Date: Wed, 29 Feb 2012 08:15:40 +0100 Message-Id: <1330499742-28091-5-git-send-email-jengelh@medozas.de> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1330499742-28091-1-git-send-email-jengelh@medozas.de> References: <1330499742-28091-1-git-send-email-jengelh@medozas.de> Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Signed-off-by: Jan Engelhardt --- src/libnetfilter_cttimeout.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/libnetfilter_cttimeout.c b/src/libnetfilter_cttimeout.c index 707543a..1f7c63e 100644 --- a/src/libnetfilter_cttimeout.c +++ b/src/libnetfilter_cttimeout.c @@ -177,7 +177,8 @@ nfct_timeout_attr_set(struct nfct_timeout *t, uint32_t type, const void *data) { switch(type) { case NFCT_TIMEOUT_ATTR_NAME: - strncpy(t->name, data, 32); + strncpy(t->name, data, sizeof(t->name)); + t->name[sizeof(t->name)-1] = '\0'; break; case NFCT_TIMEOUT_ATTR_L3PROTO: t->l3num = *((uint16_t *) data);