Patchwork [RESEND,v5,1/6] cirrus_vga: do not reset videoram

login
register
mail settings
Submitter Stefano Stabellini
Date Feb. 28, 2012, 3:51 p.m.
Message ID <1330444295-8859-1-git-send-email-stefano.stabellini@eu.citrix.com>
Download mbox | patch
Permalink /patch/143481/
State New
Headers show

Comments

Stefano Stabellini - Feb. 28, 2012, 3:51 p.m.
There is no need to set the videoram to 0xff in cirrus_reset, because it
is the BIOS' job.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 hw/cirrus_vga.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
Anthony PERARD - Feb. 28, 2012, 6:35 p.m.
On 28/02/12 15:51, Stefano Stabellini wrote:
> There is no need to set the videoram to 0xff in cirrus_reset, because it
> is the BIOS' job.
>
> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Avi Kivity - March 12, 2012, 12:43 p.m.
On 02/28/2012 05:51 PM, Stefano Stabellini wrote:
> There is no need to set the videoram to 0xff in cirrus_reset, because it
> is the BIOS' job.
>

Reviewed-by: Avi Kivity <avi@redhat.com>
Stefano Stabellini - March 12, 2012, 1:18 p.m.
On Mon, 12 Mar 2012, Avi Kivity wrote:
> On 02/28/2012 05:51 PM, Stefano Stabellini wrote:
> > There is no need to set the videoram to 0xff in cirrus_reset, because it
> > is the BIOS' job.
> >
> 
> Reviewed-by: Avi Kivity <avi@redhat.com>

thanks!!

Patch

diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 4edcb94..afedaa4 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -2767,10 +2767,6 @@  static void cirrus_reset(void *opaque)
     }
     s->vga.cr[0x27] = s->device_id;
 
-    /* Win2K seems to assume that the pattern buffer is at 0xff
-       initially ! */
-    memset(s->vga.vram_ptr, 0xff, s->real_vram_size);
-
     s->cirrus_hidden_dac_lockindex = 5;
     s->cirrus_hidden_dac_data = 0;
 }