Patchwork fwts-test: checksum-0001: update to sync with fwts checksum test

login
register
mail settings
Submitter Colin King
Date Feb. 28, 2012, 11:08 a.m.
Message ID <1330427307-26860-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/143403/
State Accepted
Headers show

Comments

Colin King - Feb. 28, 2012, 11:08 a.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 checksum-0001/checksum-0002.log |   14 ++++++++++++--
 checksum-0001/checksum-0003.log |    6 ++++++
 2 files changed, 18 insertions(+), 2 deletions(-)
Keng-Yu Lin - March 2, 2012, 11:37 a.m.
On Tue, Feb 28, 2012 at 7:08 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  checksum-0001/checksum-0002.log |   14 ++++++++++++--
>  checksum-0001/checksum-0003.log |    6 ++++++
>  2 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/checksum-0001/checksum-0002.log b/checksum-0001/checksum-0002.log
> index 1dca100..f4987af 100644
> --- a/checksum-0001/checksum-0002.log
> +++ b/checksum-0001/checksum-0002.log
> @@ -17,10 +17,20 @@ checksum        PASSED: Test 1, Table SSDT has correct checksum 0xc8.
>  checksum        PASSED: Test 1, Table SSDT has correct checksum 0x6d.
>  checksum        PASSED: Test 1, Table SSDT has correct checksum 0xdf.
>  checksum        PASSED: Test 1, Table XSDT has correct checksum 0xc2.
> -checksum        FAILED [HIGH] ACPITableChecksumRSDP: Test 1, RSDP has
> +checksum        FAILED [CRITICAL] ACPITableChecksumRSDP: Test 1, RSDP has
>  checksum        incorrect checksum, expected 0xc5, got 0xff.
> -checksum        FAILED [HIGH] ACPITableChecksumRSDP: Test 1, RSDP has
> +checksum
> +checksum        ADVICE: The kernel will not load the RSDP with an invalid
> +checksum        checksum and hence all other ACPI tables will also fail to
> +checksum        load.
> +checksum
> +checksum        FAILED [CRITICAL] ACPITableChecksumRSDP: Test 1, RSDP has
>  checksum        incorrect extended checksum, expected 0xff, got 0x39.
> +checksum
> +checksum        ADVICE: The kernel will not load the RSDP with an invalid
> +checksum        extended checksum and hence all other ACPI tables will
> +checksum        also fail to load.
> +checksum
>  checksum        PASSED: Test 1, Table RSDT has correct checksum 0x48.
>  checksum
>  checksum        =========================================================
> diff --git a/checksum-0001/checksum-0003.log b/checksum-0001/checksum-0003.log
> index 2c67877..3ef8877 100644
> --- a/checksum-0001/checksum-0003.log
> +++ b/checksum-0001/checksum-0003.log
> @@ -3,6 +3,12 @@ checksum        ---------------------------------------------------------
>  checksum        Test 1 of 1: Check ACPI table checksums.
>  checksum        FAILED [LOW] ACPITableChecksum: Test 1, Table DSDT has
>  checksum        incorrect checksum, expected 0x11, got 0x10.
> +checksum
> +checksum        ADVICE: The kernel will warn that this table has an
> +checksum        invalid checksum but will ignore the error and still load
> +checksum        it. This is not a critical issue, but should be fixed if
> +checksum        possible to avoid the warning messages.
> +checksum
>  checksum        PASSED: Test 1, Table FACP has correct checksum 0x52.
>  checksum        PASSED: Test 1, Table APIC has correct checksum 0xcc.
>  checksum        PASSED: Test 1, Table HPET has correct checksum 0xa.
> --
> 1.7.9
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - March 9, 2012, 6:42 a.m.
On 02/28/2012 07:08 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   checksum-0001/checksum-0002.log |   14 ++++++++++++--
>   checksum-0001/checksum-0003.log |    6 ++++++
>   2 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/checksum-0001/checksum-0002.log b/checksum-0001/checksum-0002.log
> index 1dca100..f4987af 100644
> --- a/checksum-0001/checksum-0002.log
> +++ b/checksum-0001/checksum-0002.log
> @@ -17,10 +17,20 @@ checksum        PASSED: Test 1, Table SSDT has correct checksum 0xc8.
>   checksum        PASSED: Test 1, Table SSDT has correct checksum 0x6d.
>   checksum        PASSED: Test 1, Table SSDT has correct checksum 0xdf.
>   checksum        PASSED: Test 1, Table XSDT has correct checksum 0xc2.
> -checksum        FAILED [HIGH] ACPITableChecksumRSDP: Test 1, RSDP has
> +checksum        FAILED [CRITICAL] ACPITableChecksumRSDP: Test 1, RSDP has
>   checksum        incorrect checksum, expected 0xc5, got 0xff.
> -checksum        FAILED [HIGH] ACPITableChecksumRSDP: Test 1, RSDP has
> +checksum
> +checksum        ADVICE: The kernel will not load the RSDP with an invalid
> +checksum        checksum and hence all other ACPI tables will also fail to
> +checksum        load.
> +checksum
> +checksum        FAILED [CRITICAL] ACPITableChecksumRSDP: Test 1, RSDP has
>   checksum        incorrect extended checksum, expected 0xff, got 0x39.
> +checksum
> +checksum        ADVICE: The kernel will not load the RSDP with an invalid
> +checksum        extended checksum and hence all other ACPI tables will
> +checksum        also fail to load.
> +checksum
>   checksum        PASSED: Test 1, Table RSDT has correct checksum 0x48.
>   checksum
>   checksum        =========================================================
> diff --git a/checksum-0001/checksum-0003.log b/checksum-0001/checksum-0003.log
> index 2c67877..3ef8877 100644
> --- a/checksum-0001/checksum-0003.log
> +++ b/checksum-0001/checksum-0003.log
> @@ -3,6 +3,12 @@ checksum        ---------------------------------------------------------
>   checksum        Test 1 of 1: Check ACPI table checksums.
>   checksum        FAILED [LOW] ACPITableChecksum: Test 1, Table DSDT has
>   checksum        incorrect checksum, expected 0x11, got 0x10.
> +checksum
> +checksum        ADVICE: The kernel will warn that this table has an
> +checksum        invalid checksum but will ignore the error and still load
> +checksum        it. This is not a critical issue, but should be fixed if
> +checksum        possible to avoid the warning messages.
> +checksum
>   checksum        PASSED: Test 1, Table FACP has correct checksum 0x52.
>   checksum        PASSED: Test 1, Table APIC has correct checksum 0xcc.
>   checksum        PASSED: Test 1, Table HPET has correct checksum 0xa.
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/checksum-0001/checksum-0002.log b/checksum-0001/checksum-0002.log
index 1dca100..f4987af 100644
--- a/checksum-0001/checksum-0002.log
+++ b/checksum-0001/checksum-0002.log
@@ -17,10 +17,20 @@  checksum        PASSED: Test 1, Table SSDT has correct checksum 0xc8.
 checksum        PASSED: Test 1, Table SSDT has correct checksum 0x6d.
 checksum        PASSED: Test 1, Table SSDT has correct checksum 0xdf.
 checksum        PASSED: Test 1, Table XSDT has correct checksum 0xc2.
-checksum        FAILED [HIGH] ACPITableChecksumRSDP: Test 1, RSDP has
+checksum        FAILED [CRITICAL] ACPITableChecksumRSDP: Test 1, RSDP has
 checksum        incorrect checksum, expected 0xc5, got 0xff.
-checksum        FAILED [HIGH] ACPITableChecksumRSDP: Test 1, RSDP has
+checksum        
+checksum        ADVICE: The kernel will not load the RSDP with an invalid
+checksum        checksum and hence all other ACPI tables will also fail to
+checksum        load.
+checksum        
+checksum        FAILED [CRITICAL] ACPITableChecksumRSDP: Test 1, RSDP has
 checksum        incorrect extended checksum, expected 0xff, got 0x39.
+checksum        
+checksum        ADVICE: The kernel will not load the RSDP with an invalid
+checksum        extended checksum and hence all other ACPI tables will
+checksum        also fail to load.
+checksum        
 checksum        PASSED: Test 1, Table RSDT has correct checksum 0x48.
 checksum        
 checksum        =========================================================
diff --git a/checksum-0001/checksum-0003.log b/checksum-0001/checksum-0003.log
index 2c67877..3ef8877 100644
--- a/checksum-0001/checksum-0003.log
+++ b/checksum-0001/checksum-0003.log
@@ -3,6 +3,12 @@  checksum        ---------------------------------------------------------
 checksum        Test 1 of 1: Check ACPI table checksums.
 checksum        FAILED [LOW] ACPITableChecksum: Test 1, Table DSDT has
 checksum        incorrect checksum, expected 0x11, got 0x10.
+checksum        
+checksum        ADVICE: The kernel will warn that this table has an
+checksum        invalid checksum but will ignore the error and still load
+checksum        it. This is not a critical issue, but should be fixed if
+checksum        possible to avoid the warning messages.
+checksum        
 checksum        PASSED: Test 1, Table FACP has correct checksum 0x52.
 checksum        PASSED: Test 1, Table APIC has correct checksum 0xcc.
 checksum        PASSED: Test 1, Table HPET has correct checksum 0xa.