Patchwork [GIT,PULL] LPC32xx fixes for v3.3-rc4

login
register
mail settings
Submitter stigge@antcom.de
Date Feb. 25, 2012, 4:30 p.m.
Message ID <4F490CC0.5050303@antcom.de>
Download mbox
Permalink /patch/143060/
State New
Headers show

Pull-request

git://git.antcom.de/linux-2.6.git lpc32xx-fixes

Comments

stigge@antcom.de - Feb. 25, 2012, 4:30 p.m.
Hi Arnd and Olof,

the fixes for LPC32xx that I just posted as patches are also available as a
git branch to pull from as described below.

Thanks in advance,

Roland



The following changes since commit b01543dfe67bb1d191998e90d20534dc354de059:

  Linux 3.3-rc4 (2012-02-18 15:53:33 -0800)

are available in the git repository at:

  git://git.antcom.de/linux-2.6.git lpc32xx-fixes

for you to fetch changes up to 3eddb16b7b275162c62f67bb75cc6bbe0ef8c075:

  ARM: LPC32xx: serial.c: Fixed loop limit (2012-02-25 16:32:44 +0100)

----------------------------------------------------------------
Roland Stigge (6):
      ARM: LPC32xx: Fix irq on GPI_28
      ARM: LPC32xx: Fix missing and bad LPC32XX macros
      ARM: LPC32xx: Fix interrupt controller init
      ARM: LPC32xx: irq.c: Clear latched event
      ARM: LPC32xx: serial.c: HW bug workaround
      ARM: LPC32xx: serial.c: Fixed loop limit

 arch/arm/mach-lpc32xx/include/mach/irqs.h     |    2 +-
 arch/arm/mach-lpc32xx/include/mach/platform.h |   51 +++++++++++++------------
 arch/arm/mach-lpc32xx/irq.c                   |   25 ++++++++++--
 arch/arm/mach-lpc32xx/pm.c                    |    2 +-
 arch/arm/mach-lpc32xx/serial.c                |   20 +++++++++-
 arch/arm/mach-lpc32xx/timer.c                 |   48 ++++++++++++------------
 6 files changed, 92 insertions(+), 56 deletions(-)
Arnd Bergmann - Feb. 27, 2012, 2:09 p.m.
On Saturday 25 February 2012, Roland Stigge wrote:
> the fixes for LPC32xx that I just posted as patches are also available as a
> git branch to pull from as described below.
> 
> The following changes since commit b01543dfe67bb1d191998e90d20534dc354de059:
> 
>   Linux 3.3-rc4 (2012-02-18 15:53:33 -0800)
> 
> are available in the git repository at:
> 
>   git://git.antcom.de/linux-2.6.git lpc32xx-fixes
> 
> for you to fetch changes up to 3eddb16b7b275162c62f67bb75cc6bbe0ef8c075:
> 
>   ARM: LPC32xx: serial.c: Fixed loop limit (2012-02-25 16:32:44 +0100)

Hi Roland,

The patch look all good, but it's not clear where you would like to
see them applied. The largest one "ARM: LPC32xx: Fix missing and bad
LPC32XX macros" looks like it is only of cosmetic nature and should
go into the next/fixes-non-critical branch for v3.4, while the
others look like they are requried for v3.3, some of them
also for earlier versions. Remember that any bug fix that applies
to older kernels should have a "Cc: stable@vger.kernel.org" tag
so that Greg can automatically pick up the fixes and port them
to the stable and longterm releases.

	Arnd
stigge@antcom.de - Feb. 27, 2012, 4:46 p.m.
Hi Arnd and Wolfram,

thanks for your notes!

On 02/27/2012 03:09 PM, Arnd Bergmann wrote:
> The patch look all good, but it's not clear where you would like to
> see them applied. The largest one "ARM: LPC32xx: Fix missing and bad
> LPC32XX macros" looks like it is only of cosmetic nature and should
> go into the next/fixes-non-critical branch for v3.4, while the
> others look like they are requried for v3.3

Right. I replaced the mentioned branch with

* lpc32xx/fixes-non-critical (singled out the macros fixes, for next)
* lpc32xx/fixes (the remaining 5 patches as immediate fixes)

Please note that although it's a typo fix in the macros, it's also an
internal API change.

I also added the stable-CC to the "lpc32xx/fixes" and added the note
about NXP's HW bugfix as suggested by Wolfram.

I'll regenerate the pull request. Please tell me if you also like to
have the patches re-posted.

Thanks in advance,

Roland
Arnd Bergmann - Feb. 27, 2012, 5:43 p.m.
On Monday 27 February 2012, Roland Stigge wrote:
> Right. I replaced the mentioned branch with
> 
> * lpc32xx/fixes-non-critical (singled out the macros fixes, for next)
> * lpc32xx/fixes (the remaining 5 patches as immediate fixes)
> 
> Please note that although it's a typo fix in the macros, it's also an
> internal API change.

I would not regard that patch any different because it changes
symbol names in the header file: The kernel internal API has absolutely
no relevance and can be changed in any (helpful) way as long as you
change all the in-kernel users at the same time.

> I also added the stable-CC to the "lpc32xx/fixes" and added the note
> about NXP's HW bugfix as suggested by Wolfram.
> 
> I'll regenerate the pull request. Please tell me if you also like to
> have the patches re-posted.

Ok, thanks a lot! There is no need to resend the patches, since they
have not changed.

	Arnd
Arnd Bergmann - Feb. 27, 2012, 5:45 p.m.
On Monday 27 February 2012, Roland Stigge wrote:
> I adjusted the patches as discussed at the new branch described below.
> 
> It's now a collection of fixes that apply to v3.3-rc5 immediately, including
> CC: stable. The patch that didn't fit there is singled out now, separately.
> 

Applied to "fixes" branch.

Thanks,

	Arnd
Arnd Bergmann - Feb. 27, 2012, 6 p.m.
On Monday 27 February 2012, Roland Stigge wrote:
> Hi Arnd and Olof,
> 
> this is the singled out separate fix, as discussed.
> 
> It applies cleanly to v3.3-rc5 and is intended for
> next/fixes-non-critical for v3.4.
> 

Ok, pulled into next/fixes-non-critical now. Thanks,

	Arnd