| Message ID | 1330178223-31717-1-git-send-email-sw@weilnetz.de |
|---|---|
| State | Accepted |
| Headers | show |
On 02/25/2012 06:57 AM, Stefan Weil wrote: > This was not a bug, but it is not common practice to omit the break statement > from the last case statement before an empty default case. > > Any change of the default case would introduce a bug. > > This was reported as a warning by splint. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > ui/vnc-enc-hextile-template.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-template.h > index b9f9f5e..a7310e1 100644 > --- a/ui/vnc-enc-hextile-template.h > +++ b/ui/vnc-enc-hextile-template.h > @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs, > /* we really don't have to invalidate either the bg or fg > but we've lost the old values. oh well. */ > } > + break; TABs vs. space looks odd. Does this file also need a whitespace cleanup?
Am 25.02.2012 15:18, schrieb Eric Blake: > On 02/25/2012 06:57 AM, Stefan Weil wrote: >> This was not a bug, but it is not common practice to omit the break statement >> from the last case statement before an empty default case. >> >> Any change of the default case would introduce a bug. >> >> This was reported as a warning by splint. >> >> Signed-off-by: Stefan Weil<sw@weilnetz.de> >> --- >> ui/vnc-enc-hextile-template.h | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-template.h >> index b9f9f5e..a7310e1 100644 >> --- a/ui/vnc-enc-hextile-template.h >> +++ b/ui/vnc-enc-hextile-template.h >> @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs, >> /* we really don't have to invalidate either the bg or fg >> but we've lost the old values. oh well. */ >> } >> + break; > TABs vs. space looks odd. Does this file also need a whitespace cleanup? 2 times yes. It's not the only file with tabs instead of spaces.
Am 25.02.2012 14:57, schrieb Stefan Weil: > This was not a bug, but it is not common practice to omit the break statement > from the last case statement before an empty default case. > > Any change of the default case would introduce a bug. > > This was reported as a warning by splint. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > ui/vnc-enc-hextile-template.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-template.h > index b9f9f5e..a7310e1 100644 > --- a/ui/vnc-enc-hextile-template.h > +++ b/ui/vnc-enc-hextile-template.h > @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs, > /* we really don't have to invalidate either the bg or fg > but we've lost the old values. oh well. */ > } > + break; > default: Doesn't that require a fallthrough comment for other tools then? Andreas > break; > }
Am 25.02.2012 16:57, schrieb Andreas Färber: > Am 25.02.2012 14:57, schrieb Stefan Weil: >> This was not a bug, but it is not common practice to omit the break >> statement >> from the last case statement before an empty default case. >> >> Any change of the default case would introduce a bug. >> >> This was reported as a warning by splint. >> >> Signed-off-by: Stefan Weil <sw@weilnetz.de> >> --- >> ui/vnc-enc-hextile-template.h | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/ui/vnc-enc-hextile-template.h >> b/ui/vnc-enc-hextile-template.h >> index b9f9f5e..a7310e1 100644 >> --- a/ui/vnc-enc-hextile-template.h >> +++ b/ui/vnc-enc-hextile-template.h >> @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, >> NAME)(VncState *vs, >> /* we really don't have to invalidate either the bg or fg >> but we've lost the old values. oh well. */ >> } >> + break; >> default: > > Doesn't that require a fallthrough comment for other tools then? > > Andreas It was a fall through (so a comment would have satisfied static code analyzers), but with the added 'break' it no longer is. As I tried to explain in the commit message, a fall through would not be reasonable in this special case. Cheers, Stefan
Am 25.02.2012 17:09, schrieb Stefan Weil: > Am 25.02.2012 16:57, schrieb Andreas Färber: >> Am 25.02.2012 14:57, schrieb Stefan Weil: >>> This was not a bug, but it is not common practice to omit the break >>> statement >>> from the last case statement before an empty default case. >>> >>> Any change of the default case would introduce a bug. >>> >>> This was reported as a warning by splint. >>> >>> Signed-off-by: Stefan Weil <sw@weilnetz.de> >>> --- >>> ui/vnc-enc-hextile-template.h | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/ui/vnc-enc-hextile-template.h >>> b/ui/vnc-enc-hextile-template.h >>> index b9f9f5e..a7310e1 100644 >>> --- a/ui/vnc-enc-hextile-template.h >>> +++ b/ui/vnc-enc-hextile-template.h >>> @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, >>> NAME)(VncState *vs, >>> /* we really don't have to invalidate either the bg or fg >>> but we've lost the old values. oh well. */ >>> } >>> + break; >>> default: >> >> Doesn't that require a fallthrough comment for other tools then? >> >> Andreas > > It was a fall through (so a comment would have satisfied static code > analyzers), but with the added 'break' it no longer is. > > As I tried to explain in the commit message, a fall through would > not be reasonable in this special case. Ah sorry, my comment was based on reading "omit break before default" in the commit message; tired, should've looked more closely. FWIW: Reviewed-by: Andreas Färber <afaerber@suse.de> Andreas
diff --git a/ui/vnc-enc-hextile-template.h b/ui/vnc-enc-hextile-template.h index b9f9f5e..a7310e1 100644 --- a/ui/vnc-enc-hextile-template.h +++ b/ui/vnc-enc-hextile-template.h @@ -175,6 +175,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs, /* we really don't have to invalidate either the bg or fg but we've lost the old values. oh well. */ } + break; default: break; }
This was not a bug, but it is not common practice to omit the break statement from the last case statement before an empty default case. Any change of the default case would introduce a bug. This was reported as a warning by splint. Signed-off-by: Stefan Weil <sw@weilnetz.de> --- ui/vnc-enc-hextile-template.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)