Patchwork Fix sign of sscanf format specifiers

login
register
mail settings
Submitter Stefan Weil
Date Feb. 25, 2012, 1:11 p.m.
Message ID <1330175506-19167-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/143052/
State Accepted
Headers show

Comments

Stefan Weil - Feb. 25, 2012, 1:11 p.m.
All values read by sscanf are unsigned, so replace %d by %u.

This signed / unsigned mismatch was detected by splint.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 cursor.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Stefan Hajnoczi - March 5, 2012, 1:12 p.m.
On Sat, Feb 25, 2012 at 02:11:46PM +0100, Stefan Weil wrote:
> All values read by sscanf are unsigned, so replace %d by %u.
> 
> This signed / unsigned mismatch was detected by splint.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  cursor.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/cursor.c b/cursor.c
index efc5917..76e262c 100644
--- a/cursor.c
+++ b/cursor.c
@@ -15,7 +15,8 @@  static QEMUCursor *cursor_parse_xpm(const char *xpm[])
     uint8_t idx;
 
     /* parse header line: width, height, #colors, #chars */
-    if (sscanf(xpm[line], "%d %d %d %d", &width, &height, &colors, &chars) != 4) {
+    if (sscanf(xpm[line], "%u %u %u %u",
+               &width, &height, &colors, &chars) != 4) {
         fprintf(stderr, "%s: header parse error: \"%s\"\n",
                 __FUNCTION__, xpm[line]);
         return NULL;