Patchwork [1/4] qapi-schema: fix typos and explain 'spice' auth

login
register
mail settings
Submitter Alon Levy
Date Feb. 24, 2012, 9:22 p.m.
Message ID <1330118525-14522-1-git-send-email-alevy@redhat.com>
Download mbox | patch
Permalink /patch/142974/
State New
Headers show

Comments

Alon Levy - Feb. 24, 2012, 9:22 p.m.
Signed-off-by: Alon Levy <alevy@redhat.com>
---
 qapi-schema.json |   18 ++++++++++--------
 1 files changed, 10 insertions(+), 8 deletions(-)
Alon Levy - Feb. 28, 2012, 8:05 a.m.
On Fri, Feb 24, 2012 at 11:22:02PM +0200, Alon Levy wrote:
> Signed-off-by: Alon Levy <alevy@redhat.com>

Ping.

> ---
>  qapi-schema.json |   18 ++++++++++--------
>  1 files changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index d0b6792..72b17f1 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -616,12 +616,13 @@
>  # @connection-id: SPICE connection id number.  All channels with the same id
>  #                 belong to the same SPICE session.
>  #
> -# @connection-type: SPICE channel type number.  "1" is the main control channel,
> -#                   filter for this one if you want track spice sessions only
> +# @connection-type: SPICE channel type number.  "1" is the main control
> +#                   channel, filter for this one if you want to track spice
> +#                   sessions only
>  #
> -# @channel-id: SPICE channel ID number.  Usually "0", might be different needed
> -#              when multiple channels of the same type exist, such as multiple
> -#              display channels in a multihead setup
> +# @channel-id: SPICE channel ID number.  Usually "0", might be different when
> +#                   multiple channels of the same type exist, such as multiple
> +#                   display channels in a multihead setup
>  #
>  # @tls: true if the channel is encrypted, false otherwise.
>  #
> @@ -649,8 +650,9 @@
>  # @tls-port: #optional The SPICE server's TLS port number.
>  #
>  # @auth: #optional the current authentication type used by the server
> -#        'none' if no authentication is being used
> -#        'spice' (TODO: describe)
> +#        'none'  if no authentication is being used
> +#        'spice' uses SASL or direct TLS authentication, depending on command
> +#                line options
>  #
>  # @channels: a list of @SpiceChannel for each active spice channel
>  #
> @@ -1216,7 +1218,7 @@
>  { 'command': 'migrate_set_speed', 'data': {'value': 'int'} }
>  
>  ##
> -# @DevicePropertyInfo:
> +# @ObjectPropertyInfo:
>  #
>  # @name: the name of the property
>  #
> -- 
> 1.7.9.1
> 
>
Luiz Capitulino - Feb. 28, 2012, 7:57 p.m.
On Fri, 24 Feb 2012 23:22:02 +0200
Alon Levy <alevy@redhat.com> wrote:

> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
>  qapi-schema.json |   18 ++++++++++--------
>  1 files changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index d0b6792..72b17f1 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -616,12 +616,13 @@
>  # @connection-id: SPICE connection id number.  All channels with the same id
>  #                 belong to the same SPICE session.
>  #
> -# @connection-type: SPICE channel type number.  "1" is the main control channel,
> -#                   filter for this one if you want track spice sessions only
> +# @connection-type: SPICE channel type number.  "1" is the main control
> +#                   channel, filter for this one if you want to track spice
> +#                   sessions only
>  #
> -# @channel-id: SPICE channel ID number.  Usually "0", might be different needed
> -#              when multiple channels of the same type exist, such as multiple
> -#              display channels in a multihead setup
> +# @channel-id: SPICE channel ID number.  Usually "0", might be different when
> +#                   multiple channels of the same type exist, such as multiple
> +#                   display channels in a multihead setup
>  #
>  # @tls: true if the channel is encrypted, false otherwise.
>  #
> @@ -649,8 +650,9 @@
>  # @tls-port: #optional The SPICE server's TLS port number.
>  #
>  # @auth: #optional the current authentication type used by the server
> -#        'none' if no authentication is being used
> -#        'spice' (TODO: describe)
> +#        'none'  if no authentication is being used
> +#        'spice' uses SASL or direct TLS authentication, depending on command
> +#                line options
>  #
>  # @channels: a list of @SpiceChannel for each active spice channel
>  #
> @@ -1216,7 +1218,7 @@
>  { 'command': 'migrate_set_speed', 'data': {'value': 'int'} }
>  
>  ##
> -# @DevicePropertyInfo:
> +# @ObjectPropertyInfo:
>  #
>  # @name: the name of the property
>  #

This last hunk is unrelated to this series.
Alon Levy - Feb. 29, 2012, 8:40 a.m.
On Tue, Feb 28, 2012 at 04:57:10PM -0300, Luiz Capitulino wrote:
> On Fri, 24 Feb 2012 23:22:02 +0200
> Alon Levy <alevy@redhat.com> wrote:
> 
> > Signed-off-by: Alon Levy <alevy@redhat.com>
> > ---
> >  qapi-schema.json |   18 ++++++++++--------
> >  1 files changed, 10 insertions(+), 8 deletions(-)
> > 
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index d0b6792..72b17f1 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -616,12 +616,13 @@
> >  # @connection-id: SPICE connection id number.  All channels with the same id
> >  #                 belong to the same SPICE session.
> >  #
> > -# @connection-type: SPICE channel type number.  "1" is the main control channel,
> > -#                   filter for this one if you want track spice sessions only
> > +# @connection-type: SPICE channel type number.  "1" is the main control
> > +#                   channel, filter for this one if you want to track spice
> > +#                   sessions only
> >  #
> > -# @channel-id: SPICE channel ID number.  Usually "0", might be different needed
> > -#              when multiple channels of the same type exist, such as multiple
> > -#              display channels in a multihead setup
> > +# @channel-id: SPICE channel ID number.  Usually "0", might be different when
> > +#                   multiple channels of the same type exist, such as multiple
> > +#                   display channels in a multihead setup
> >  #
> >  # @tls: true if the channel is encrypted, false otherwise.
> >  #
> > @@ -649,8 +650,9 @@
> >  # @tls-port: #optional The SPICE server's TLS port number.
> >  #
> >  # @auth: #optional the current authentication type used by the server
> > -#        'none' if no authentication is being used
> > -#        'spice' (TODO: describe)
> > +#        'none'  if no authentication is being used
> > +#        'spice' uses SASL or direct TLS authentication, depending on command
> > +#                line options
> >  #
> >  # @channels: a list of @SpiceChannel for each active spice channel
> >  #
> > @@ -1216,7 +1218,7 @@
> >  { 'command': 'migrate_set_speed', 'data': {'value': 'int'} }
> >  
> >  ##
> > -# @DevicePropertyInfo:
> > +# @ObjectPropertyInfo:
> >  #
> >  # @name: the name of the property
> >  #
> 
> This last hunk is unrelated to this series.

I'll send it separately.

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index d0b6792..72b17f1 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -616,12 +616,13 @@ 
 # @connection-id: SPICE connection id number.  All channels with the same id
 #                 belong to the same SPICE session.
 #
-# @connection-type: SPICE channel type number.  "1" is the main control channel,
-#                   filter for this one if you want track spice sessions only
+# @connection-type: SPICE channel type number.  "1" is the main control
+#                   channel, filter for this one if you want to track spice
+#                   sessions only
 #
-# @channel-id: SPICE channel ID number.  Usually "0", might be different needed
-#              when multiple channels of the same type exist, such as multiple
-#              display channels in a multihead setup
+# @channel-id: SPICE channel ID number.  Usually "0", might be different when
+#                   multiple channels of the same type exist, such as multiple
+#                   display channels in a multihead setup
 #
 # @tls: true if the channel is encrypted, false otherwise.
 #
@@ -649,8 +650,9 @@ 
 # @tls-port: #optional The SPICE server's TLS port number.
 #
 # @auth: #optional the current authentication type used by the server
-#        'none' if no authentication is being used
-#        'spice' (TODO: describe)
+#        'none'  if no authentication is being used
+#        'spice' uses SASL or direct TLS authentication, depending on command
+#                line options
 #
 # @channels: a list of @SpiceChannel for each active spice channel
 #
@@ -1216,7 +1218,7 @@ 
 { 'command': 'migrate_set_speed', 'data': {'value': 'int'} }
 
 ##
-# @DevicePropertyInfo:
+# @ObjectPropertyInfo:
 #
 # @name: the name of the property
 #