diff mbox

[net-next-2.6] xfrm: remove unneeded method typedef declaration in net/xfrm.h.

Message ID CAHLOa7SLiHakXirjV2Q2tnC0u-zZuZp1s8sk+y3iZXevGw0ZDQ@mail.gmail.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Rami Rosen Feb. 24, 2012, 12:17 p.m. UTC
Hi,

 The patch removes unneeded method typedef declaration
(icv_update_fn_t ) in net/xfrm.h.
(I am sending the same patch again as my former mail was  rejected by
the vger server, now I believe it will be fine).

icv_update_fn_t was used in the past, for example in xfrm_algo.c (as a
parameter to skb_icv_walk() method), but it is no longer used
anywhere.

This patch removes it and the two struct declarations which appear in
its prototype

 (struct hash_desc and struct scatterlist)


Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

Comments

David Miller Feb. 24, 2012, 8:02 p.m. UTC | #1
From: Rami Rosen <ramirose@gmail.com>
Date: Fri, 24 Feb 2012 14:17:24 +0200

>  The patch removes unneeded method typedef declaration

Where are all of these underscores coming from in your email
text?

Please turn off all fancy encodings in your email client.

> Regards,
> Rami Rosen

Things like this do not belong in your commit message, if you leave it
in there then I have to edit it out which is more work for me.

> Signed-off-by: Rami Rosen <ramirose@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/net/xfrm.h b/include/net/xfrm.h
index 89174e2..96239e7 100644
--- a/include/net/xfrm.h
+++ b/include/net/xfrm.h
@@ -1566,11 +1566,6 @@  extern struct xfrm_algo_desc *xfrm_calg_get_byname(const char *name, int probe);
 extern struct xfrm_algo_desc *xfrm_aead_get_byname(const char *name, int icv_len,
 						   int probe);
 
-struct hash_desc;
-struct scatterlist;
-typedef int (icv_update_fn_t)(struct hash_desc *, struct scatterlist *,
-			      unsigned int);
-
 static inline int xfrm_addr_cmp(const xfrm_address_t *a,
 				const xfrm_address_t *b,
 				int family)