From patchwork Fri Feb 24 09:27:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Henderson, Stuart" X-Patchwork-Id: 142764 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 88FC5B6FCC for ; Fri, 24 Feb 2012 20:27:36 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1330680458; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:Received:Received:Received:From:To:CC: Date:Subject:Message-ID:References:In-Reply-To:Content-Type: MIME-Version:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=P1npN1A mbYq4iVMivK7hUAq357A=; b=w/A2enACPvxHl3Dhne+kuqZYfrSNXb/Bx1ObcMH OKrBKXqUTnYu2DNLzdNKHlBQpG9Ti5lIqoF+knozxSYWaE7AnsUAn2OSHaVgbrlX Nr3Btk3PG5MPF+au4+yJpXa2ahwDh2OLiy5A592GJE/h42Fk8pKd6UVWrHbv18ip YwXY= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:X-SpamScore:X-BigFish:X-Forefront-Antispam-Report:Received:Received:Received:Received:Received:Received:From:To:CC:Date:Subject:Message-ID:References:In-Reply-To:Content-Type:MIME-Version:X-OriginatorOrg:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=OebNNZtlPhvj9uS+26J1lM4NqTd/l6qnivq3UcAj6jQpC8Su9zRg5V5rLR5w9I fv3cnzPWyA3HvkyxAtPSW+dw1gcpXIBYRPGYmGomin2p59C+rMzE34ODrZpA6HQY L9bPpuxdkE80lbY/x/pId6AzuV5jEkXbOx4P4zS7dlQ3U=; Received: (qmail 20780 invoked by alias); 24 Feb 2012 09:27:32 -0000 Received: (qmail 20772 invoked by uid 22791); 24 Feb 2012 09:27:31 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from va3ehsobe005.messaging.microsoft.com (HELO VA3EHSOBE003.bigfish.com) (216.32.180.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Feb 2012 09:27:16 +0000 Received: from mail73-va3-R.bigfish.com (10.7.14.248) by VA3EHSOBE003.bigfish.com (10.7.40.23) with Microsoft SMTP Server id 14.1.225.23; Fri, 24 Feb 2012 09:27:14 +0000 Received: from mail73-va3 (localhost [127.0.0.1]) by mail73-va3-R.bigfish.com (Postfix) with ESMTP id A7793400205; Fri, 24 Feb 2012 09:27:14 +0000 (UTC) X-SpamScore: -10 X-BigFish: VPS-10(zzc85fh1432N111aLzz1202hzzz2dh2a8h668h839h34h) X-Forefront-Antispam-Report: CIP:137.71.25.55; KIP:(null); UIP:(null); IPV:NLI; H:nwd2mta1.analog.com; RD:nwd2mail10.analog.com; EFVD:NLI Received: from mail73-va3 (localhost.localdomain [127.0.0.1]) by mail73-va3 (MessageSwitch) id 1330075632699740_10665; Fri, 24 Feb 2012 09:27:12 +0000 (UTC) Received: from VA3EHSMHS019.bigfish.com (unknown [10.7.14.242]) by mail73-va3.bigfish.com (Postfix) with ESMTP id 9BE6A160045; Fri, 24 Feb 2012 09:27:12 +0000 (UTC) Received: from nwd2mta1.analog.com (137.71.25.55) by VA3EHSMHS019.bigfish.com (10.7.99.29) with Microsoft SMTP Server (TLS) id 14.1.225.23; Fri, 24 Feb 2012 09:27:12 +0000 Received: from NWD2HUBCAS1.ad.analog.com (nwd2hubcas1.ad.analog.com [10.64.73.29]) by nwd2mta1.analog.com (8.13.8/8.13.8) with ESMTP id q1O9ISAF009846 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 24 Feb 2012 04:18:28 -0500 Received: from LimkHubCAS1.ad.analog.com (10.32.51.140) by NWD2HUBCAS1.ad.analog.com (10.64.73.29) with Microsoft SMTP Server (TLS) id 8.3.83.0; Fri, 24 Feb 2012 04:28:05 -0500 Received: from LIMKCMBX1.ad.analog.com ([169.254.1.182]) by LimkHubCAS1.ad.analog.com ([10.32.51.140]) with mapi; Fri, 24 Feb 2012 09:28:04 +0000 From: "Henderson, Stuart" To: "gcc-patches@gcc.gnu.org" CC: Bernd Schmidt Date: Fri, 24 Feb 2012 09:27:05 +0000 Subject: RE: spill failure after IF-CASE-2 transformation Message-ID: <05E9E85E39C35B4D96ED3A3190E35A10AF0C7F17CA@LIMKCMBX1.ad.analog.com> References: <05E9E85E39C35B4D96ED3A3190E35A10AF0C445892@LIMKCMBX1.ad.analog.com> <4F32A9D6.6080204@codesourcery.com> <05E9E85E39C35B4D96ED3A3190E35A10AF0C514920@LIMKCMBX1.ad.analog.com> <4F426B8D.6050907@codesourcery.com> <05E9E85E39C35B4D96ED3A3190E35A10AF0C78F6AB@LIMKCMBX1.ad.analog.com> <4F44EF8A.20405@codesourcery.com> <05E9E85E39C35B4D96ED3A3190E35A10AF0C78F8B5@LIMKCMBX1.ad.analog.com> <4F451BAB.9010703@codesourcery.com> In-Reply-To: <4F451BAB.9010703@codesourcery.com> MIME-Version: 1.0 X-OriginatorOrg: analog.com X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org >I think this is a fairly reasonable minimal fix. For 4.8 we could >experiment whether to always do this, regardless of s_r_c_f_m_p. > >Ok if bootstrapped and tested on a primary target (i.e. linux) and >tested on Blackfin. > > >Bernd Thanks again, Bernd. Forwarding to gcc-patches to give people a couple of days to object. Tested on linux and bfin. Stu diff --git a/gcc/ifcvt.c b/gcc/ifcvt.c index 8d81c89..e4e13ab 100644 --- a/gcc/ifcvt.c +++ b/gcc/ifcvt.c @@ -2295,7 +2295,9 @@ noce_get_condition (rtx jump, rtx *earliest, bool then_else_reversed) cond = XEXP (SET_SRC (set), 0); tmp = XEXP (cond, 0); - if (REG_P (tmp) && GET_MODE_CLASS (GET_MODE (tmp)) == MODE_INT) + if (REG_P (tmp) && GET_MODE_CLASS (GET_MODE (tmp)) == MODE_INT + && (GET_MODE (tmp) != BImode + || !targetm.small_register_classes_for_mode_p (BImode))) { *earliest = jump;