Patchwork tg3: remove IRQF_SAMPLE_RANDOM flag

login
register
mail settings
Submitter Davidlohr Bueso
Date Feb. 22, 2012, 1:06 p.m.
Message ID <1329916014.2586.2.camel@offbook>
Download mbox | patch
Permalink /patch/142453/
State Accepted
Delegated to: David Miller
Headers show

Comments

Davidlohr Bueso - Feb. 22, 2012, 1:06 p.m.
From: Davidlohr Bueso <dave@gnu.org>

This driver is the last user of the IRQF_SAMPLE_RANDOM flag for net drivers, and since add_*_randomness
interfaces have now deprecated the flag as a source of external noise, we can remove it.

Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
 drivers/net/ethernet/broadcom/tg3.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Feb. 22, 2012, 7:57 p.m.
From: Davidlohr Bueso <dave@gnu.org>
Date: Wed, 22 Feb 2012 14:06:54 +0100

> From: Davidlohr Bueso <dave@gnu.org>
> 
> This driver is the last user of the IRQF_SAMPLE_RANDOM flag for net drivers, and since add_*_randomness
> interfaces have now deprecated the flag as a source of external noise, we can remove it.
> 
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index a1f2e0f..2badfc3 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -9401,7 +9401,7 @@  static int tg3_test_interrupt(struct tg3 *tp)
 	}
 
 	err = request_irq(tnapi->irq_vec, tg3_test_isr,
-			  IRQF_SHARED | IRQF_SAMPLE_RANDOM, dev->name, tnapi);
+			  IRQF_SHARED, dev->name, tnapi);
 	if (err)
 		return err;