Patchwork Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

login
register
mail settings
Submitter 陳韋任
Date Feb. 21, 2012, 10:12 a.m.
Message ID <20120221101239.GA95445@cs.nctu.edu.tw>
Download mbox | patch
Permalink /patch/142308/
State New
Headers show

Comments

陳韋任 - Feb. 21, 2012, 10:12 a.m.
Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge
helper, but introduces dependency issue at the same time. While building target
xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated
at the moment. Building recurse-all target first fixes the problem.  

Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
陳韋任 - Feb. 22, 2012, 2:08 a.m.
On Tue, Feb 21, 2012 at 12:27:26PM +0000, Stefan Hajnoczi wrote:
> On Tue, Feb 21, 2012 at 10:12 AM, 陳韋任 <chenwj@iis.sinica.edu.tw> wrote:
> >  Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge
> > helper, but introduces dependency issue at the same time. While building target
> > xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated
> > at the moment. Building recurse-all target first fixes the problem.
> 
> The build system should not rely on ordering side-effects.  Instead,
> please explicitly declare the dependency for the helper or see if the
> dependency can be eliminated if it is inappropriate.

  O.K., since the dependency cannot be eliminated, I'll explicitly declare the
dependency for the helper.

Regards,
chenwj

Patch

diff --git a/Makefile b/Makefile
index e66e885..618b306 100644
--- a/Makefile
+++ b/Makefile
@@ -79,7 +79,7 @@  defconfig:
 
 -include config-all-devices.mak
 
-build-all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all
+build-all: $(DOCS) $(TOOLS) recurse-all $(HELPERS-y)
 
 config-host.h: config-host.h-timestamp
 config-host.h-timestamp: config-host.mak