| Message ID | alpine.LRH.2.02.1202192018500.16782@bear.techie.net |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Scott Talbert <talbert@techie.net> Date: Sun, 19 Feb 2012 20:35:29 -0500 (EST) > The Logitech Harmony 900 remote control appears to use the pseudo-MDLM > driver, rather than the standard one. This patch simply moves the > device so that it gets picked up by the correct driver. > > Signed-off-by: Scott Talbert <talbert@techie.net> You're not moving anything, you're adding the ID to not one but two different drivers. That doesn't make any sense to me, so either this patch is completely wrong or you need to rewrite your commit message to explain things better and more accurately. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 20 Feb 2012, David Miller wrote: > From: Scott Talbert <talbert@techie.net> > Date: Sun, 19 Feb 2012 20:35:29 -0500 (EST) > >> The Logitech Harmony 900 remote control appears to use the pseudo-MDLM >> driver, rather than the standard one. This patch simply moves the >> device so that it gets picked up by the correct driver. >> >> Signed-off-by: Scott Talbert <talbert@techie.net> > > You're not moving anything, you're adding the ID to not one but two > different drivers. > > That doesn't make any sense to me, so either this patch is completely > wrong or you need to rewrite your commit message to explain things > better and more accurately. Sorry, to clarify...in the current baseline, the Harmony 900 gets picked up by the cdc_ether driver by this generic line in cdc_ether.c: USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), .driver_info = (unsigned long)&wwan_info, The intent of my patch is to blacklist the Harmony 900 from cdc_ether and whitelist it in zaurus. Scott -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Scott Talbert <talbert@techie.net> Date: Mon, 20 Feb 2012 19:50:57 -0500 (EST) > On Mon, 20 Feb 2012, David Miller wrote: > >> From: Scott Talbert <talbert@techie.net> >> Date: Sun, 19 Feb 2012 20:35:29 -0500 (EST) >> >>> The Logitech Harmony 900 remote control appears to use the pseudo-MDLM >>> driver, rather than the standard one. This patch simply moves the >>> device so that it gets picked up by the correct driver. >>> >>> Signed-off-by: Scott Talbert <talbert@techie.net> >> >> You're not moving anything, you're adding the ID to not one but two >> different drivers. >> >> That doesn't make any sense to me, so either this patch is completely >> wrong or you need to rewrite your commit message to explain things >> better and more accurately. > > Sorry, to clarify...in the current baseline, the Harmony 900 gets > picked up by the cdc_ether driver by this generic line in cdc_ether.c: > > USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM, > USB_CDC_PROTO_NONE), > .driver_info = (unsigned long)&wwan_info, > > The intent of my patch is to blacklist the Harmony 900 from cdc_ether > and whitelist it in zaurus. Please freshly repost your patch with an updated commit message. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index c924ea2..13919dd 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c @@ -570,6 +570,13 @@ static const struct usb_device_id products [] = { .driver_info = (unsigned long)&wwan_info, }, +/* Logitech Harmony 900 - uses the pseudo-MDLM (BLAN) driver */ +{ + USB_DEVICE_AND_INTERFACE_INFO(0x046d, 0xc11f, USB_CLASS_COMM, + USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), + .driver_info = 0, +}, + /* * WHITELIST!!! * diff --git a/drivers/net/usb/zaurus.c b/drivers/net/usb/zaurus.c index 1a2234c..246b3bb 100644 --- a/drivers/net/usb/zaurus.c +++ b/drivers/net/usb/zaurus.c @@ -349,6 +349,13 @@ static const struct usb_device_id products [] = { ZAURUS_MASTER_INTERFACE, .driver_info = OLYMPUS_MXL_INFO, }, + +/* Logitech Harmony 900 - uses the pseudo-MDLM (BLAN) driver */ +{ + USB_DEVICE_AND_INTERFACE_INFO(0x046d, 0xc11f, USB_CLASS_COMM, + USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE), + .driver_info = (unsigned long) &bogus_mdlm_info, +}, { }, // END }; MODULE_DEVICE_TABLE(usb, products);
Hello, The Logitech Harmony 900 remote control appears to use the pseudo-MDLM driver, rather than the standard one. This patch simply moves the device so that it gets picked up by the correct driver. Signed-off-by: Scott Talbert <talbert@techie.net> --- drivers/net/usb/cdc_ether.c | 7 +++++++ drivers/net/usb/zaurus.c | 7 +++++++ 2 files changed, 14 insertions(+), 0 deletions(-)