From patchwork Sat Feb 18 17:11:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 142039 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 92644B6EF1 for ; Sun, 19 Feb 2012 04:12:31 +1100 (EST) Received: from localhost ([::1]:55687 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rynpk-0004Vp-DQ for incoming@patchwork.ozlabs.org; Sat, 18 Feb 2012 12:12:28 -0500 Received: from eggs.gnu.org ([140.186.70.92]:50186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RynpV-0004HL-OQ for qemu-devel@nongnu.org; Sat, 18 Feb 2012 12:12:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RynpU-0005mY-0r for qemu-devel@nongnu.org; Sat, 18 Feb 2012 12:12:13 -0500 Received: from mail-bk0-f45.google.com ([209.85.214.45]:63774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RynpT-0005kY-Hz for qemu-devel@nongnu.org; Sat, 18 Feb 2012 12:12:11 -0500 Received: by mail-bk0-f45.google.com with SMTP id e19so4291536bku.4 for ; Sat, 18 Feb 2012 09:12:11 -0800 (PST) Received-SPF: pass (google.com: domain of jcmvbkbc@gmail.com designates 10.204.155.132 as permitted sender) client-ip=10.204.155.132; Authentication-Results: mr.google.com; spf=pass (google.com: domain of jcmvbkbc@gmail.com designates 10.204.155.132 as permitted sender) smtp.mail=jcmvbkbc@gmail.com; dkim=pass header.i=jcmvbkbc@gmail.com Received: from mr.google.com ([10.204.155.132]) by 10.204.155.132 with SMTP id s4mr7519806bkw.43.1329585131208 (num_hops = 1); Sat, 18 Feb 2012 09:12:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=ntulDqZSOSqvb1S2gVAxX+UWIRNBMMjWGWJSGvFIWkI=; b=uH9p7N2tfTsD8l605/hukXbmSzxwf8rHsBa+PiFY1/MZolj2pvCC+zNr2fduZQFj/t eDeYjwIRweSsBxXwj/mcOjONeeT9yJKZvzKBUgmG0DdW8cTjahHk6hosvKkCrs1EclPx y6GqMn5ddAR9siSGGWa7CWBDFO66X+AaXFp3o= Received: by 10.204.155.132 with SMTP id s4mr6099424bkw.43.1329585131134; Sat, 18 Feb 2012 09:12:11 -0800 (PST) Received: from octofox.metropolis ([188.134.19.124]) by mx.google.com with ESMTPS id o7sm28887600bkw.16.2012.02.18.09.12.09 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 18 Feb 2012 09:12:10 -0800 (PST) From: Max Filippov To: qemu-devel@nongnu.org Date: Sat, 18 Feb 2012 21:11:34 +0400 Message-Id: <1329585103-31371-3-git-send-email-jcmvbkbc@gmail.com> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1329585103-31371-1-git-send-email-jcmvbkbc@gmail.com> References: <1329564636-29883-1-git-send-email-jcmvbkbc@gmail.com> <1329585103-31371-1-git-send-email-jcmvbkbc@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.45 Cc: blauwirbel@gmail.com, Max Filippov , aliguori@us.ibm.com, afaerber@suse.de Subject: [Qemu-devel] [PATCH 03/12] target-xtensa: fetch 3rd opcode byte only when needed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org According to ISA, 3.5.4, third opcode byte should not be fetched for 2-byte instructions. Signed-off-by: Max Filippov --- target-xtensa/translate.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c index c81450d..6a0177f 100644 --- a/target-xtensa/translate.c +++ b/target-xtensa/translate.c @@ -749,7 +749,7 @@ static void disas_xtensa_insn(DisasContext *dc) uint8_t b0 = ldub_code(dc->pc); uint8_t b1 = ldub_code(dc->pc + 1); - uint8_t b2 = ldub_code(dc->pc + 2); + uint8_t b2 = 0; static const uint32_t B4CONST[] = { 0xffffffff, 1, 2, 3, 4, 5, 6, 7, 8, 10, 12, 16, 32, 64, 128, 256 @@ -764,6 +764,7 @@ static void disas_xtensa_insn(DisasContext *dc) HAS_OPTION(XTENSA_OPTION_CODE_DENSITY); } else { dc->next_pc = dc->pc + 3; + b2 = ldub_code(dc->pc + 2); } switch (OP0) {