| Message ID | 1329564636-29883-1-git-send-email-jcmvbkbc@gmail.com |
|---|---|
| State | New |
| Headers | show |
Am 18.02.2012 12:30, schrieb Max Filippov: > Hi. > > This is a pull request for my current target-xtensa queue. > Changes in the queue are: > - 'info tlb' monitor command; > - debug option implementation; > - a few minor fixes. > > Debug option series has been posted to the list as an RFC, there were no changes > in it since then. It would be nice to see those 12 patches threaded to the PULL message, especially when there's been no feedback yet (which may indicate either that people had no objections or didn't look at it yet). Andreas > > Please pull. > > Thanks. > -- Max > > The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: > > input: send kbd+mouse events only to running guests. (2012-02-17 11:02:55 -0600) > > are available in the git repository at: > git://jcmvbkbc.spb.ru/dumb/qemu-xtensa.git xtensa > > Max Filippov (12): > target-xtensa: define TLB_TEMPLATE for MMU-less cores > target-xtensa: implement info tlb monitor command > target-xtensa: fetch 3rd opcode byte only when needed > target-xtensa: add DEBUGCAUSE SR and configuration > target-xtensa: implement instruction breakpoints > target-xtensa: add ICOUNT SR and debug exception > exec: add missing breaks to the watch_mem_write > exec: fix check_watchpoint exiting cpu_loop > exec: let cpu_watchpoint_insert accept larger watchpoints > target-xtensa: add DBREAK data breakpoints > target-xtensa: add DEBUG_SECTION to overlay tool > target-xtensa: add breakpoint tests > > exec.c | 18 +++- > hmp-commands.hx | 2 +- > monitor.c | 4 +- > target-xtensa/core-dc232b.c | 1 + > target-xtensa/core-fsf.c | 1 + > target-xtensa/cpu.h | 43 ++++++++ > target-xtensa/helper.c | 110 ++++++++++++++++++++ > target-xtensa/helpers.h | 7 ++ > target-xtensa/op_helper.c | 100 ++++++++++++++++++ > target-xtensa/overlay_tool.h | 23 ++++- > target-xtensa/translate.c | 156 ++++++++++++++++++++++++++++- > tests/tcg/xtensa/Makefile | 1 + > tests/tcg/xtensa/test_break.S | 223 +++++++++++++++++++++++++++++++++++++++++ > 13 files changed, 674 insertions(+), 15 deletions(-) > create mode 100644 tests/tcg/xtensa/test_break.S
Thanks, incidentally: Am 18.02.2012 18:11, schrieb Max Filippov: > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> Reviewed-by is missing. Care to fix on your branch? I don't see any Rb/Ab on the others as well, please check. Andreas > --- > exec.c | 12 +++++++++--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/exec.c b/exec.c > index b81677a..f105b43 100644 > --- a/exec.c > +++ b/exec.c > @@ -3289,9 +3289,15 @@ static void watch_mem_write(void *opaque, target_phys_addr_t addr, > { > check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WRITE); > switch (size) { > - case 1: stb_phys(addr, val); > - case 2: stw_phys(addr, val); > - case 4: stl_phys(addr, val); > + case 1: > + stb_phys(addr, val); > + break; > + case 2: > + stw_phys(addr, val); > + break; > + case 4: > + stl_phys(addr, val); > + break; > default: abort(); > } > }
> Thanks, incidentally: > > Am 18.02.2012 18:11, schrieb Max Filippov: > > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> > > Reviewed-by is missing. Care to fix on your branch? Done. > I don't see any Rb/Ab on the others as well, please check. A haven't got any other Rb/Ab. Thanks. -- Max
> Hi. > > This is a pull request for my current target-xtensa queue. > Changes in the queue are: > - 'info tlb' monitor command; > - debug option implementation; > - a few minor fixes. ping? > > Debug option series has been posted to the list as an RFC, there were no changes > in it since then. > > Please pull. > > Thanks. > -- Max > > The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: > > input: send kbd+mouse events only to running guests. (2012-02-17 11:02:55 -0600) > > are available in the git repository at: > git://jcmvbkbc.spb.ru/dumb/qemu-xtensa.git xtensa > > Max Filippov (12): > target-xtensa: define TLB_TEMPLATE for MMU-less cores > target-xtensa: implement info tlb monitor command > target-xtensa: fetch 3rd opcode byte only when needed > target-xtensa: add DEBUGCAUSE SR and configuration > target-xtensa: implement instruction breakpoints > target-xtensa: add ICOUNT SR and debug exception > exec: add missing breaks to the watch_mem_write > exec: fix check_watchpoint exiting cpu_loop > exec: let cpu_watchpoint_insert accept larger watchpoints > target-xtensa: add DBREAK data breakpoints > target-xtensa: add DEBUG_SECTION to overlay tool > target-xtensa: add breakpoint tests > > exec.c | 18 +++- > hmp-commands.hx | 2 +- > monitor.c | 4 +- > target-xtensa/core-dc232b.c | 1 + > target-xtensa/core-fsf.c | 1 + > target-xtensa/cpu.h | 43 ++++++++ > target-xtensa/helper.c | 110 ++++++++++++++++++++ > target-xtensa/helpers.h | 7 ++ > target-xtensa/op_helper.c | 100 ++++++++++++++++++ > target-xtensa/overlay_tool.h | 23 ++++- > target-xtensa/translate.c | 156 ++++++++++++++++++++++++++++- > tests/tcg/xtensa/Makefile | 1 + > tests/tcg/xtensa/test_break.S | 223 +++++++++++++++++++++++++++++++++++++++++ > 13 files changed, 674 insertions(+), 15 deletions(-) > create mode 100644 tests/tcg/xtensa/test_break.S > > -- > 1.7.7.6
On Sun, Feb 26, 2012 at 17:34, Max Filippov <jcmvbkbc@gmail.com> wrote: >> Hi. >> >> This is a pull request for my current target-xtensa queue. >> Changes in the queue are: >> - 'info tlb' monitor command; >> - debug option implementation; >> - a few minor fixes. > > ping? Thanks, pulled. >> >> Debug option series has been posted to the list as an RFC, there were no changes >> in it since then. >> >> Please pull. >> >> Thanks. >> -- Max >> >> The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: >> >> input: send kbd+mouse events only to running guests. (2012-02-17 11:02:55 -0600) >> >> are available in the git repository at: >> git://jcmvbkbc.spb.ru/dumb/qemu-xtensa.git xtensa >> >> Max Filippov (12): >> target-xtensa: define TLB_TEMPLATE for MMU-less cores >> target-xtensa: implement info tlb monitor command >> target-xtensa: fetch 3rd opcode byte only when needed >> target-xtensa: add DEBUGCAUSE SR and configuration >> target-xtensa: implement instruction breakpoints >> target-xtensa: add ICOUNT SR and debug exception >> exec: add missing breaks to the watch_mem_write >> exec: fix check_watchpoint exiting cpu_loop >> exec: let cpu_watchpoint_insert accept larger watchpoints >> target-xtensa: add DBREAK data breakpoints >> target-xtensa: add DEBUG_SECTION to overlay tool >> target-xtensa: add breakpoint tests >> >> exec.c | 18 +++- >> hmp-commands.hx | 2 +- >> monitor.c | 4 +- >> target-xtensa/core-dc232b.c | 1 + >> target-xtensa/core-fsf.c | 1 + >> target-xtensa/cpu.h | 43 ++++++++ >> target-xtensa/helper.c | 110 ++++++++++++++++++++ >> target-xtensa/helpers.h | 7 ++ >> target-xtensa/op_helper.c | 100 ++++++++++++++++++ >> target-xtensa/overlay_tool.h | 23 ++++- >> target-xtensa/translate.c | 156 ++++++++++++++++++++++++++++- >> tests/tcg/xtensa/Makefile | 1 + >> tests/tcg/xtensa/test_break.S | 223 +++++++++++++++++++++++++++++++++++++++++ >> 13 files changed, 674 insertions(+), 15 deletions(-) >> create mode 100644 tests/tcg/xtensa/test_break.S >> >> -- >> 1.7.7.6 > > -- > Thanks. > -- Max