Patchwork [U-Boot] microblaze: fix build failure due to undefined reference to `get_ticks'

login
register
mail settings
Submitter Stephan Linz
Date Feb. 18, 2012, 10:50 a.m.
Message ID <1329562218-5003-1-git-send-email-linz@li-pro.net>
Download mbox | patch
Permalink /patch/142035/
State Accepted
Commit b9f0b7305278feba7dc295e58c58f22cfcfe8009
Delegated to: Michal Simek
Headers show

Comments

Stephan Linz - Feb. 18, 2012, 10:50 a.m.
after http://patchwork.ozlabs.org/patch/136415/ was applied.
The Microblaze generic build fails with below error

common/libcommon.o: In function `cread_line':
/devel/u-boot/common/main.c:717: undefined reference to `get_ticks'
/devel/u-boot/common/main.c:717: undefined reference to `get_tbclk'
/devel/u-boot/common/main.c:720: undefined reference to `get_ticks'

Signed-off-by: Stephan Linz <linz@li-pro.net>
---
 arch/microblaze/cpu/timer.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)
Michal Simek - Feb. 22, 2012, 9:52 a.m.
Stephan Linz wrote:
> after http://patchwork.ozlabs.org/patch/136415/ was applied.
> The Microblaze generic build fails with below error

Please sure patch subject + sha1 sum instead of link to system
which doesn't need to work in future. Git reference will work.

Thanks,
Michal
Stephan Linz - Feb. 22, 2012, 6:04 p.m.
Am Mittwoch, den 22.02.2012, 10:52 +0100 schrieb Michal Simek: 
> Stephan Linz wrote:
> > after http://patchwork.ozlabs.org/patch/136415/ was applied.
> > The Microblaze generic build fails with below error
> 
> Please sure patch subject + sha1 sum instead of link to system
> which doesn't need to work in future. Git reference will work.

OK, I'll resend the patch. Can I already add your ACK ?
Michal Simek - Feb. 22, 2012, 6:19 p.m.
Stephan Linz <linz@li-pro.net> napsal(a):

>Am Mittwoch, den 22.02.2012, 10:52 +0100 schrieb Michal Simek: 
>> Stephan Linz wrote:
>> > after http://patchwork.ozlabs.org/patch/136415/ was applied.
>> > The Microblaze generic build fails with below error
>> 
>> Please sure patch subject + sha1 sum instead of link to system
>> which doesn't need to work in future. Git reference will work.
>
>OK, I'll resend the patch. Can I already add your ACK ?

Yes, you can.

Michal

Patch

diff --git a/arch/microblaze/cpu/timer.c b/arch/microblaze/cpu/timer.c
index a167755..1952804 100644
--- a/arch/microblaze/cpu/timer.c
+++ b/arch/microblaze/cpu/timer.c
@@ -62,3 +62,21 @@  int timer_init (void)
 }
 #endif
 #endif
+
+/*
+ * This function is derived from PowerPC code (read timebase as long long).
+ * On Microblaze it just returns the timer value.
+ */
+unsigned long long get_ticks(void)
+{
+	return get_timer(0);
+}
+
+/*
+ * This function is derived from PowerPC code (timebase clock frequency).
+ * On Microblaze it returns the number of timer ticks per second.
+ */
+ulong get_tbclk(void)
+{
+	return CONFIG_SYS_HZ;
+}