Patchwork [21/30] KVM: PPC: make e500v2 and e500mc mutually exclusive

login
register
mail settings
Submitter Alexander Graf
Date Feb. 17, 2012, 4:56 p.m.
Message ID <1329497818-9729-22-git-send-email-agraf@suse.de>
Download mbox | patch
Permalink /patch/141933/
State Not Applicable
Headers show

Comments

Alexander Graf - Feb. 17, 2012, 4:56 p.m.
We can't build e500v2 and e500mc (kvm) support inside the same kernel.
So indicate that by making the 2 options mutually exclusive in kconfig.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/powerpc/kvm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Tabi Timur-B04825 - Feb. 17, 2012, 10:32 p.m.
On Fri, Feb 17, 2012 at 10:56 AM, Alexander Graf <agraf@suse.de> wrote:

>  config KVM_E500MC
>        bool "KVM support for PowerPC E500MC/E5500 processors"
> -       depends on EXPERIMENTAL && PPC_E500MC
> +       depends on EXPERIMENTAL && PPC_E500MC && !KVM_E500V2

There was a patch floating around that made a similar change to the
platform support, so that you could either build an e500v2 kernel and
enable support only for e500v2 board, or you could build an e500mc
kernel and enable support only for e500mc boards.  Last I heard, the
patch wasn't quite working, but that was a while ago.

Is there a connection between this patch and that one?
Alexander Graf - Feb. 17, 2012, 11:27 p.m.
On 17.02.2012, at 23:32, Tabi Timur-B04825 wrote:

> On Fri, Feb 17, 2012 at 10:56 AM, Alexander Graf <agraf@suse.de> wrote:
> 
>>  config KVM_E500MC
>>        bool "KVM support for PowerPC E500MC/E5500 processors"
>> -       depends on EXPERIMENTAL && PPC_E500MC
>> +       depends on EXPERIMENTAL && PPC_E500MC && !KVM_E500V2
> 
> There was a patch floating around that made a similar change to the
> platform support, so that you could either build an e500v2 kernel and
> enable support only for e500v2 board, or you could build an e500mc
> kernel and enable support only for e500mc boards.  Last I heard, the
> patch wasn't quite working, but that was a while ago.
> 
> Is there a connection between this patch and that one?

No, and the code paths are quite orthogonal. While today it's impossible to build a kernel that can drive e500v2 and e500mc systems, it might be possible one day. That still doesn't buy us KVM compatibility between the two though. And vice versa. We could improve the KVM code to actually be versatile between the two platforms, but then you still couldn't run the same kernel on both ;).


Alex

Patch

diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index 44a998d..25ffc1e 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -134,7 +134,7 @@  config KVM_E500V2
 
 config KVM_E500MC
 	bool "KVM support for PowerPC E500MC/E5500 processors"
-	depends on EXPERIMENTAL && PPC_E500MC
+	depends on EXPERIMENTAL && PPC_E500MC && !KVM_E500V2
 	select KVM
 	select KVM_MMIO
 	select KVM_BOOKE_HV