Patchwork [PULL] of nand generic binding

login
register
mail settings
Submitter Jean-Christophe PLAGNIOL-VILLARD
Date Feb. 17, 2012, 3:57 p.m.
Message ID <20120217155707.GR1214@game.jcrosoft.org>
Download mbox
Permalink /patch/141865/
State New
Headers show

Pull-request

git://github.com/at91linux/linux-at91.git for-grant-dt

Comments

Jean-Christophe PLAGNIOL-VILLARD - Feb. 17, 2012, 3:57 p.m.
HI,

	please find attached the generic binding for the MTD nand

	This will add boolean and nand helpers

The following changes since commit d65b4e98d7ea3038b767b70fe8be959b2913f16d:

  Linux 3.3-rc3 (2012-02-08 19:21:53 -0800)

are available in the git repository at:
  git://github.com/at91linux/linux-at91.git for-grant-dt

Jean-Christophe PLAGNIOL-VILLARD (2):
      of: introduce helper to manage boolean
      of/mtd/nand: add generic bindings and helpers

 Documentation/devicetree/bindings/mtd/nand.txt |    7 ++
 drivers/of/Kconfig                             |    4 +
 drivers/of/Makefile                            |    1 +
 drivers/of/base.c                              |   30 ++++++++
 drivers/of/of_mtd.c                            |   85 ++++++++++++++++++++++++
 include/linux/of.h                             |    8 ++
 include/linux/of_mtd.h                         |   19 +++++
 7 files changed, 154 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mtd/nand.txt
 create mode 100644 drivers/of/of_mtd.c
 create mode 100644 include/linux/of_mtd.h

Best Regards,
J.
Jean-Christophe PLAGNIOL-VILLARD - Feb. 29, 2012, 3:25 p.m.
On 16:57 Fri 17 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> HI,
> 
> 	please find attached the generic binding for the MTD nand
> 
> 	This will add boolean and nand helpers
is it ok?

Best Regards,
J.
> 
> The following changes since commit d65b4e98d7ea3038b767b70fe8be959b2913f16d:
> 
>   Linux 3.3-rc3 (2012-02-08 19:21:53 -0800)
> 
> are available in the git repository at:
>   git://github.com/at91linux/linux-at91.git for-grant-dt
> 
> Jean-Christophe PLAGNIOL-VILLARD (2):
>       of: introduce helper to manage boolean
>       of/mtd/nand: add generic bindings and helpers
> 
>  Documentation/devicetree/bindings/mtd/nand.txt |    7 ++
>  drivers/of/Kconfig                             |    4 +
>  drivers/of/Makefile                            |    1 +
>  drivers/of/base.c                              |   30 ++++++++
>  drivers/of/of_mtd.c                            |   85 ++++++++++++++++++++++++
>  include/linux/of.h                             |    8 ++
>  include/linux/of_mtd.h                         |   19 +++++
>  7 files changed, 154 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mtd/nand.txt
>  create mode 100644 drivers/of/of_mtd.c
>  create mode 100644 include/linux/of_mtd.h
> 
> Best Regards,
> J.
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Jean-Christophe PLAGNIOL-VILLARD - March 7, 2012, 8:29 a.m.
On 16:25 Wed 29 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 16:57 Fri 17 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> > HI,
> > 
> > 	please find attached the generic binding for the MTD nand
> > 
> > 	This will add boolean and nand helpers
> is it ok?
I need this for 3.4

will you apply it or can I apply it via AT91

Best Regards,
J.
Rob Herring - March 7, 2012, 1:43 p.m.
On 03/07/2012 02:29 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 16:25 Wed 29 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 16:57 Fri 17 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> HI,
>>>
>>> 	please find attached the generic binding for the MTD nand
>>>
>>> 	This will add boolean and nand helpers
>> is it ok?
> I need this for 3.4
> 
> will you apply it or can I apply it via AT91

Looks fine to me and Grant acked it, so go ahead and take with your at91
branch.

Rob

> 
> Best Regards,
> J.
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
Jean-Christophe PLAGNIOL-VILLARD - March 7, 2012, 4:28 p.m.
On 07:43 Wed 07 Mar     , Rob Herring wrote:
> On 03/07/2012 02:29 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 16:25 Wed 29 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> >> On 16:57 Fri 17 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>> HI,
> >>>
> >>> 	please find attached the generic binding for the MTD nand
> >>>
> >>> 	This will add boolean and nand helpers
> >> is it ok?
> > I need this for 3.4
> > 
> > will you apply it or can I apply it via AT91
> 
> Looks fine to me and Grant acked it, so go ahead and take with your at91
> branch.
tks

can you take a look on i2c-gpio and usb and dma_mask patch I send

I wish them to go for 3.4

so I'll have 60 to 80% of the drivers depending on the soc.

for 3.5 we need to finish some cleanup to have finnaly multiple at91 SoC in
the same kernel and add more drivers to DT.

This will allow people to have DT-only kernel on at91 for they board.

Best Regards,
J.
Grant Likely - March 9, 2012, 1:44 a.m.
On Wed, 07 Mar 2012 07:43:30 -0600, Rob Herring <robherring2@gmail.com> wrote:
> On 03/07/2012 02:29 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 16:25 Wed 29 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> >> On 16:57 Fri 17 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>> HI,
> >>>
> >>> 	please find attached the generic binding for the MTD nand
> >>>
> >>> 	This will add boolean and nand helpers
> >> is it ok?
> > I need this for 3.4
> > 
> > will you apply it or can I apply it via AT91
> 
> Looks fine to me and Grant acked it, so go ahead and take with your at91
> branch.

Actually, taking another look at the of_mtd patch, that stuff really
belongs in the drivers/mtd directory.  I'm not nacking the patch, but
you should send a follow up to move it into the correct place.

I don't like the of_property_read_bool patch.  I don't want the
of_property_read_ functions to mix data return and error codes.
Either return a bool with an error code in the parameter list, or the
other way around.  Otherwise we'll end up with the same problem as
APIs that use the ERR_PTR() pattern where callers will use it without
understanding that the return value isn't necessarily a bool.

g.

> 
> Rob
> 
> > 
> > Best Regards,
> > J.
> > _______________________________________________
> > devicetree-discuss mailing list
> > devicetree-discuss@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/devicetree-discuss
>
Jean-Christophe PLAGNIOL-VILLARD - March 9, 2012, 10:09 a.m.
On 18:44 Thu 08 Mar     , Grant Likely wrote:
> On Wed, 07 Mar 2012 07:43:30 -0600, Rob Herring <robherring2@gmail.com> wrote:
> > On 03/07/2012 02:29 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 16:25 Wed 29 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> > >> On 16:57 Fri 17 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> > >>> HI,
> > >>>
> > >>> 	please find attached the generic binding for the MTD nand
> > >>>
> > >>> 	This will add boolean and nand helpers
> > >> is it ok?
> > > I need this for 3.4
> > > 
> > > will you apply it or can I apply it via AT91
> > 
> > Looks fine to me and Grant acked it, so go ahead and take with your at91
> > branch.
> 
> Actually, taking another look at the of_mtd patch, that stuff really
> belongs in the drivers/mtd directory.  I'm not nacking the patch, but
> you should send a follow up to move it into the correct place.
today of generic binding are all in drivers/of


> 
> I don't like the of_property_read_bool patch.  I don't want the
> of_property_read_ functions to mix data return and error codes.
> Either return a bool with an error code in the parameter list, or the
> other way around.  Otherwise we'll end up with the same problem as
> APIs that use the ERR_PTR() pattern where callers will use it without
> understanding that the return value isn't necessarily a bool.
I update as I reply

and can I've a go I've all the binding for at91 reallying on it

Best Regards,
J.
Jean-Christophe PLAGNIOL-VILLARD - March 9, 2012, 11:40 a.m.
On 18:44 Thu 08 Mar     , Grant Likely wrote:
> On Wed, 07 Mar 2012 07:43:30 -0600, Rob Herring <robherring2@gmail.com> wrote:
> > On 03/07/2012 02:29 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 16:25 Wed 29 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> > >> On 16:57 Fri 17 Feb     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> > >>> HI,
> > >>>
> > >>> 	please find attached the generic binding for the MTD nand
> > >>>
> > >>> 	This will add boolean and nand helpers
> > >> is it ok?
> > > I need this for 3.4
> > > 
> > > will you apply it or can I apply it via AT91
> > 
> > Looks fine to me and Grant acked it, so go ahead and take with your at91
> > branch.
> 
> Actually, taking another look at the of_mtd patch, that stuff really
> belongs in the drivers/mtd directory.  I'm not nacking the patch, but
> you should send a follow up to move it into the correct place.
ok

Best Regards,
J.