| Message ID | 1329493411-25750-3-git-send-email-danny.kukawka@bisect.de |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Danny Kukawka <danny.kukawka@bisect.de> Date: Fri, 17 Feb 2012 16:43:23 +0100 > Set addr_assign_type correctly to NET_ADDR_RANDOM in case > a random MAC address was generated and assigned to the netdevice. > > v2: added comment, renamed bool variable to random_mac > > Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de> More bad comment formatting. > + /*set addr_assign_type here, ltq_etop_set_mac_address would reset it*/ Again, I fixed it up but I will not next time. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Freitag, 17. Februar 2012, David Miller wrote: > From: Danny Kukawka <danny.kukawka@bisect.de> > Date: Fri, 17 Feb 2012 16:43:23 +0100 > > > Set addr_assign_type correctly to NET_ADDR_RANDOM in case > > a random MAC address was generated and assigned to the netdevice. > > > > v2: added comment, renamed bool variable to random_mac > > > > Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de> > > More bad comment formatting. > > > + /*set addr_assign_type here, ltq_etop_set_mac_address would reset it*/ > > Again, I fixed it up but I will not next time. Thanks. I fixed it but accidently send the unfixed version of the patches without noticing. Sorry. Danny -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index 85e2c6c..aee87fc 100644 --- a/drivers/net/ethernet/lantiq_etop.c +++ b/drivers/net/ethernet/lantiq_etop.c @@ -634,6 +634,7 @@ ltq_etop_init(struct net_device *dev) struct ltq_etop_priv *priv = netdev_priv(dev); struct sockaddr mac; int err; + bool random_mac = false; ether_setup(dev); dev->watchdog_timeo = 10 * HZ; @@ -646,11 +647,17 @@ ltq_etop_init(struct net_device *dev) if (!is_valid_ether_addr(mac.sa_data)) { pr_warn("etop: invalid MAC, using random\n"); random_ether_addr(mac.sa_data); + random_mac = true; } err = ltq_etop_set_mac_address(dev, &mac); if (err) goto err_netdev; + + /*set addr_assign_type here, ltq_etop_set_mac_address would reset it*/ + if (random_mac) + dev->addr_assign_type |= NET_ADDR_RANDOM; + ltq_etop_set_multicast_list(dev); err = ltq_etop_mdio_init(dev); if (err)
Set addr_assign_type correctly to NET_ADDR_RANDOM in case a random MAC address was generated and assigned to the netdevice. v2: added comment, renamed bool variable to random_mac Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de> --- drivers/net/ethernet/lantiq_etop.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)