Patchwork [22/22] hw/pl031: Actually raise interrupt on timer expiry

login
register
mail settings
Submitter Peter Maydell
Date Feb. 17, 2012, 11:29 a.m.
Message ID <1329478177-14650-23-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/141783/
State New
Headers show

Comments

Peter Maydell - Feb. 17, 2012, 11:29 a.m.
Fix a typo in pl031_interrupt() which meant we were setting a bit
in the interrupt mask rather than the interrupt status register
and thus not actually raising an interrupt. This fix allows the
rtctest program from the kernel's Documentation/rtc.txt to pass
rather than hanging.

Reported-by: Daniel Forsgren <daniel.forsgren@enea.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Andreas Färber <afaerber@suse.de>
---
 hw/pl031.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/hw/pl031.c b/hw/pl031.c
index 05b5b11..69abc4f 100644
--- a/hw/pl031.c
+++ b/hw/pl031.c
@@ -76,7 +76,7 @@  static void pl031_interrupt(void * opaque)
 {
     pl031_state *s = (pl031_state *)opaque;
 
-    s->im = 1;
+    s->is = 1;
     DPRINTF("Alarm raised\n");
     pl031_update(s);
 }