From patchwork Thu Feb 16 20:47:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 141687 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C7DC01007D3 for ; Fri, 17 Feb 2012 07:48:39 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1330030120; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:From:To:Cc:Subject:References:Date:In-Reply-To: Message-ID:User-Agent:MIME-Version:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=r8K7tnrEW9/13q8uuNz9078lt/Y=; b=vJdiyfLP7VBJ/wxQ2a4W21wnzMr375111K6zZLWLYJ0q6mQiJcnzoUGonI2ffj NYyrs10xV83uljkm/wi6I3zU1BqkZxoqTPpPqPqsirJUr22Wkh1PGZygCb9fH7Oe XfRGfstpp9W/MwW9kkBQVtKgC+N7ecahbI1+ZrfWe/plk= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:User-Agent:MIME-Version:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=p1MEXOY88SUXZ4GHyNBsaxpcrnvVNcBCVjfJD5mSMS5CX/AXybX/zsU2Zz0bK5 8aYOXHZabxM9blMzB5y/JnygUdIz/fjCIKS92OVoMeEUJPvGpbw7rpbatL+3LKcC 0J+2KSri0LVXeJSTGGE7eQv7p5jSB5ANn6kSBkNu1M/zY=; Received: (qmail 22977 invoked by alias); 16 Feb 2012 20:48:33 -0000 Received: (qmail 22962 invoked by uid 22791); 16 Feb 2012 20:48:30 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, TW_ZJ, T_RP_MATCHES_RCVD, T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from snape.CeBiTec.Uni-Bielefeld.DE (HELO smtp-relay.CeBiTec.Uni-Bielefeld.DE) (129.70.160.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Feb 2012 20:47:52 +0000 Received: from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 97975335; Thu, 16 Feb 2012 21:47:50 +0100 (CET) Received: from smtp-relay.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (malfoy.CeBiTec.Uni-Bielefeld.DE [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FTAXgEtGT+u1; Thu, 16 Feb 2012 21:47:47 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (manam.CeBiTec.Uni-Bielefeld.DE [129.70.161.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-relay.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPS id D31F7334; Thu, 16 Feb 2012 21:47:47 +0100 (CET) Received: (from ro@localhost) by manam.CeBiTec.Uni-Bielefeld.DE (8.14.5+Sun/8.14.5/Submit) id q1GKljX0011312; Thu, 16 Feb 2012 21:47:45 +0100 (MET) From: Rainer Orth To: Andrew MacLeod Cc: Uros Bizjak , Aldy Hernandez , Mike Stump , Jack Howarth , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] increase timeout in simulate-thread gdb test References: <20111207184343.GA2527@bromo.med.uc.edu> <4F75A7C6-A179-48A5-9911-7C3107466634@comcast.net> <4F32747D.9010308@redhat.com> <4F32E9DF.4070103@redhat.com> <4F33D43C.9090607@redhat.com> <4F33DD94.5000009@redhat.com> Date: Thu, 16 Feb 2012 21:47:45 +0100 In-Reply-To: <4F33DD94.5000009@redhat.com> (Andrew MacLeod's message of "Thu, 09 Feb 2012 09:52:04 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (usg-unix-v) MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Andrew MacLeod writes: > On 02/09/2012 09:38 AM, Uros Bizjak wrote: >> On Thu, Feb 9, 2012 at 3:12 PM, Aldy Hernandez wrote: >> >> It was me, and the sole reason was that timeout didn't worked and the >> log filled the file system. After timeout functionality was fixed, the >> timeout was forced to 10 seconds. It is an arbitrary number. >> > I suspected as much. Long term I think we should remove the line by line > log info as the default. Even with the 20-second timeout, I was seeing lots of failures on slower machines, like sparc, alpha, or mips. I've had good success with the following patch which uses the default dejagnu timeout instead of some arbitrary value. It even takes into account users doubling the default timeout (as I have to do on IRIX). With this patch, all those FAILs on Solaris are gone, on IRIX only FAIL: gcc.dg/simulate-thread/atomic-other-int.c -O0 -g thread simulation test FAIL: gcc.dg/simulate-thread/atomic-other-int.c -O2 -g thread simulation test FAIL: gcc.dg/simulate-thread/atomic-other-int.c -O3 -g thread simulation test FAIL: gcc.dg/simulate-thread/atomic-other-short.c -O0 -g thread simulation test FAIL: gcc.dg/simulate-thread/atomic-other-short.c -O2 -g thread simulation test FAIL: gcc.dg/simulate-thread/atomic-other-short.c -O3 -g thread simulation test are left. Only on Tru64 UNIX do I still see lots of failures. I've to investigate whether or not they are timeout-related. Admittedly, it has the disadvantage of potentially filling the log files if things go badly wrong. What do you think? Rainer 2012-02-10 Rainer Orth PR target/51753 * lib/gcc-simulate-thread.exp: Load timeout.exp. (simulate-thread): Use default timeout. # HG changeset patch # Parent 20c4f5db4968654fb36aa38d0800fbee28457be3 Increase simulate-thread timeout (PR target/51753) diff --git a/gcc/testsuite/lib/gcc-simulate-thread.exp b/gcc/testsuite/lib/gcc-simulate-thread.exp --- a/gcc/testsuite/lib/gcc-simulate-thread.exp +++ b/gcc/testsuite/lib/gcc-simulate-thread.exp @@ -1,4 +1,4 @@ -# Copyright (C) 2011 Free Software Foundation, Inc. +# Copyright (C) 2011, 2012 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -14,6 +14,8 @@ # along with GCC; see the file COPYING3. If not see # . +load_lib timeout.exp + # Utility for running a given test through the simulate-thread harness # using gdb. This is invoked via dg-final. # @@ -56,8 +58,7 @@ proc simulate-thread { args } { set gdb_worked 0 - # Set timeout to 20 seconds due to huge amount of generated log. - remote_expect target 20 { + remote_expect target [timeout_value] { # Too old GDB -re "Unhandled dwarf expression|Error in sourced command file" { unsupported "$testcase $message"