Patchwork [U-Boot] mx31: add "ARM11P power gating" to get_reset_cause

login
register
mail settings
Submitter Helmut Raiger
Date Feb. 16, 2012, 8:44 a.m.
Message ID <1329381874-14023-1-git-send-email-helmut.raiger@hale.at>
Download mbox | patch
Permalink /patch/141522/
State Accepted
Commit 82081406a2acd15fb4b4beed7f91f57f56c9365f
Delegated to: Stefano Babic
Headers show

Comments

Helmut Raiger - Feb. 16, 2012, 8:44 a.m.
Add missing reset reason 7 to get_reset_cause().

Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
---
 arch/arm/cpu/arm1136/mx31/generic.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Stefano Babic - March 7, 2012, 10:16 a.m.
On 16/02/2012 09:44, Helmut Raiger wrote:
> Add missing reset reason 7 to get_reset_cause().
> 
> Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
> ---
>  arch/arm/cpu/arm1136/mx31/generic.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm1136/mx31/generic.c b/arch/arm/cpu/arm1136/mx31/generic.c
> index d60afc9..8873fb7 100644
> --- a/arch/arm/cpu/arm1136/mx31/generic.c
> +++ b/arch/arm/cpu/arm1136/mx31/generic.c
> @@ -210,6 +210,8 @@ static char *get_reset_cause(void)
>  		return "WDOG";
>  	case 0x0006:
>  		return "JTAG";
> +	case 0x0007:
> +		return "ARM11P power gating";
>  	default:
>  		return "unknown reset";
>  	}

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic
Helmut Raiger - March 7, 2012, 10:16 a.m.
On 02/16/2012 09:44 AM, Helmut Raiger wrote:
> Add missing reset reason 7 to get_reset_cause().
>
> Signed-off-by: Helmut Raiger<helmut.raiger@hale.at>
> ---
>   arch/arm/cpu/arm1136/mx31/generic.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/cpu/arm1136/mx31/generic.c b/arch/arm/cpu/arm1136/mx31/generic.c
> index d60afc9..8873fb7 100644
> --- a/arch/arm/cpu/arm1136/mx31/generic.c
> +++ b/arch/arm/cpu/arm1136/mx31/generic.c
> @@ -210,6 +210,8 @@ static char *get_reset_cause(void)
>   		return "WDOG";
>   	case 0x0006:
>   		return "JTAG";
> +	case 0x0007:
> +		return "ARM11P power gating";
>   	default:
>   		return "unknown reset";
>   	}

Please comment.
Helmut


--
Scanned by MailScanner.
Stefano Babic - March 7, 2012, 10:49 a.m.
On 07/03/2012 11:16, Helmut Raiger wrote:
> On 02/16/2012 09:44 AM, Helmut Raiger wrote:
>> Add missing reset reason 7 to get_reset_cause().
>>
>> Signed-off-by: Helmut Raiger<helmut.raiger@hale.at>

Hi Helmut,

>> ---
>>   arch/arm/cpu/arm1136/mx31/generic.c |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/cpu/arm1136/mx31/generic.c
>> b/arch/arm/cpu/arm1136/mx31/generic.c
>> index d60afc9..8873fb7 100644
>> --- a/arch/arm/cpu/arm1136/mx31/generic.c
>> +++ b/arch/arm/cpu/arm1136/mx31/generic.c
>> @@ -210,6 +210,8 @@ static char *get_reset_cause(void)
>>           return "WDOG";
>>       case 0x0006:
>>           return "JTAG";
>> +    case 0x0007:
>> +        return "ARM11P power gating";
>>       default:
>>           return "unknown reset";
>>       }
> 

???

I have applied the patch and I sent an "applied to.." message. Which
comment do you expect ?

Best regards,
Stefano Babic
Helmut Raiger - March 7, 2012, 12:42 p.m.
On 03/07/2012 11:49 AM, Stefano Babic wrote:
>
> ???
>
> I have applied the patch and I sent an "applied to.." message. Which
> comment do you expect ?
Hi Stefano,

     I received the applied to .. message at 11:16 today and this
e-mail at 11:49, the patch is from 3-weeks ago. I just wanted to push
it, no more.

Might have been an e-mail glitch?
Thanx anyway,
Helmut


--
Scanned by MailScanner.
Stefano Babic - March 7, 2012, 1:03 p.m.
On 07/03/2012 13:42, Helmut Raiger wrote:

>     I received the applied to .. message at 11:16 today and this
> e-mail at 11:49, the patch is from 3-weeks ago. I just wanted to push
> it, no more.
> 
> Might have been an e-mail glitch?

Of course, it is. We checked the status exactly at the same time. Very
improbable, but it is happen. Rather it is not a lottery and we did not
won anything ;-)

Best regards,
Stefano Babic

Patch

diff --git a/arch/arm/cpu/arm1136/mx31/generic.c b/arch/arm/cpu/arm1136/mx31/generic.c
index d60afc9..8873fb7 100644
--- a/arch/arm/cpu/arm1136/mx31/generic.c
+++ b/arch/arm/cpu/arm1136/mx31/generic.c
@@ -210,6 +210,8 @@  static char *get_reset_cause(void)
 		return "WDOG";
 	case 0x0006:
 		return "JTAG";
+	case 0x0007:
+		return "ARM11P power gating";
 	default:
 		return "unknown reset";
 	}