From patchwork Thu Feb 16 07:46:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francois Romieu X-Patchwork-Id: 141517 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 36F9CB6EF7 for ; Thu, 16 Feb 2012 18:59:11 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754744Ab2BPH7K (ORCPT ); Thu, 16 Feb 2012 02:59:10 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:53842 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753174Ab2BPH7H (ORCPT ); Thu, 16 Feb 2012 02:59:07 -0500 Received: from violet.fr.zoreil.com (localhost [127.0.0.1]) by violet.fr.zoreil.com (8.13.8/8.13.8) with ESMTP id q1G7kcfY006239; Thu, 16 Feb 2012 08:46:38 +0100 Received: (from romieu@localhost) by violet.fr.zoreil.com (8.13.8/8.13.8/Submit) id q1G7kbcs006238; Thu, 16 Feb 2012 08:46:37 +0100 Date: Thu, 16 Feb 2012 08:46:37 +0100 From: Francois Romieu To: hayeswang Cc: "'Eric Dumazet'" , "'Nick Bowler'" , netdev@vger.kernel.org Subject: Re: Bogus frames transmitted with r8169 & fragmentation & large mtu Message-ID: <20120216074637.GA6208@electric-eye.fr.zoreil.com> References: <20120215163748.GA3998@elliptictech.com> <1329333239.2469.3.camel@edumazet-laptop> <20120215232303.GB31463@electric-eye.fr.zoreil.com> <33249D172FBD4AE09E24D4F24E973BD9@realtek.com.tw> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <33249D172FBD4AE09E24D4F24E973BD9@realtek.com.tw> User-Agent: Mutt/1.4.2.2i X-Organisation: Land of Sunshine Inc. Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org hayeswang : [...] > Please add Cfg9346_Unlock before calling rtl_hw_jumbo_enable or > hw_jumbo_disable. > And, add Cfg9346_lock after calling rlt_hw_jumbo_enable or hw_jumbo_disable. Thanks. I am testing it now. --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 5eb6858..81e6ea2 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -3833,12 +3833,20 @@ static void rtl8169_init_ring_indexes(struct rtl8169_private *tp) static void rtl_hw_jumbo_enable(struct rtl8169_private *tp) { + void __iomem *ioaddr = tp->mmio_addr; + + RTL_W8(Cfg9346, Cfg9346_Unlock); rtl_generic_op(tp, tp->jumbo_ops.enable); + RTL_W8(Cfg9346, Cfg9346_Lock); } static void rtl_hw_jumbo_disable(struct rtl8169_private *tp) { + void __iomem *ioaddr = tp->mmio_addr; + + RTL_W8(Cfg9346, Cfg9346_Unlock); rtl_generic_op(tp, tp->jumbo_ops.disable); + RTL_W8(Cfg9346, Cfg9346_Lock); } static void r8168c_hw_jumbo_enable(struct rtl8169_private *tp)