Patchwork [committed] Fix a typo (PR translation/52264)

login
register
mail settings
Submitter Jakub Jelinek
Date Feb. 16, 2012, 6:32 a.m.
Message ID <20120216063238.GE18768@tyan-ft48-01.lab.bos.redhat.com>
Download mbox | patch
Permalink /patch/141509/
State New
Headers show

Comments

Jakub Jelinek - Feb. 16, 2012, 6:32 a.m.
Hi!

Bootstrapped/regtested on x86_64-linux and i686-linux,
committed to trunk as obvious:

2012-02-16  Jakub Jelinek  <jakub@redhat.com>

	PR translation/52264
	* cgraphunit.c (verify_cgraph_node): Fix a typo.


	Jakub
Mike Stump - Feb. 16, 2012, 4:59 p.m.
On Feb 15, 2012, at 10:32 PM, Jakub Jelinek wrote:
> Bootstrapped/regtested on x86_64-linux and i686-linux,
> committed to trunk as obvious:
> 
> 2012-02-16  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR translation/52264
> 	* cgraphunit.c (verify_cgraph_node): Fix a typo.
> 
> --- gcc/cgraphunit.c.jj	2012-02-12 15:46:32.000000000 +0100
> +++ gcc/cgraphunit.c	2012-02-15 21:29:25.927382754 +0100
> @@ -667,7 +667,7 @@ verify_cgraph_node (struct cgraph_node *
>       for (i = 0; ipa_ref_list_reference_iterate (&node->ref_list, i, ref); i++)
> 	if (ref->use != IPA_REF_ALIAS)
> 	  {
> -	    error ("Alias has non-alias refernece");
> +	    error ("Alias has non-alias reference");

Unless Alias means something very specific, the english word should be lower case.  Since this is the middle end, it should not refer to anything terribly specific, so, is should be lower case.
Mike Stump - Feb. 16, 2012, 5:09 p.m.
On Feb 16, 2012, at 8:59 AM, Mike Stump wrote:
>> -	    error ("Alias has non-alias refernece");
>> +	    error ("Alias has non-alias reference");
> 
> Unless Alias means something very specific, the english word should be lower case.  Since this is the middle end, it should not refer to anything terribly specific, so, is should be lower case.

Likewise:

cgraphunit.c:	  error ("An indirect edge from %s is not marked as indirect or has "
cgraphunit.c:	  error ("Alias has call edges");
cgraphunit.c:	    error ("Alias has non-alias refernece");
cgraphunit.c:	    error ("Alias has more than one alias reference");
cgraphunit.c:	    error ("Analyzed alias has no reference");
cgraphunit.c:	  error ("No edge out of thunk node");
cgraphunit.c:	  error ("More than one edge out of thunk node");
cgraphunit.c:	  error ("Thunk is not supposed to have body");
coverage.c:	      error ("Profile data for function %u is corrupted", fn_ident);
coverage.c:	      error ("Profile data for function %u is corrupted", fn_ident);
genautomata.c:      error ("Name `%s' contains quotes", name);
genautomata.c:		  error ("The following units do not satisfy units-automata distribution rule");
genautomata.c:		  error ("Reserv %s:", insn_reserv_name);
genautomata.c:		    error ("Automaton `%s': Insn `%s' will never be issued",
genautomata.c:		    error ("Insn `%s' will never be issued",
genpreds.c:	      error ("Multi-letter constraints with first letter '%c' "
lto-cgraph.c:	  fatal_error ("Profile information in %s corrupted",
passes.c:                  error ("Invalid range %s in option %s",
passes.c:		  error ("Invalid range %s in option %s",
tree-eh.c:      error ("Incorrect EH edge %i->%i", bb->index, eh_edge->dest->index);
value-prof.c:		error ("Histogram value statement does not correspond to "
value-prof.c:        error ("Inconsistent profile: indirect call target (%d) does not exist", func_id);

and for the front-ends and friends:

ada/terminals.c:      report_file_error ("Could not open exe: ", Qnil);
ada/terminals.c:      report_file_error ("Missing NT signature. Unknown file type.\n", Qnil);
ada/terminals.c:      report_file_error ("Creation of child's IN handle", Qnil);
ada/terminals.c:      report_file_error ("Creation of child's OUT handle", Qnil);
ada/terminals.c:      report_file_error ("Creation of child's OUT handle", Qnil);
ada/terminals.c:    report_file_error ("Spawning child process", Qnil);
cp/semantics.c:      error ("Parameter pack __bases only valid in template declaration");
java/jcf-dump.c:	      perror ("Could not find class");
java/jcf-io.c:	  perror ("Could not figure length of .class file");
java/jcf-io.c:	  perror ("Failed to read .class file");
java/resource.c:      perror ("Failed to read resource file");
java/resource.c:      perror ("Could not figure length of resource file");
lto/lto.c:	  fatal_error ("Cannot open %s", file_data->file_name);
lto/lto.c:      fatal_error ("Cannot map %s", file_data->file_name);
lto/lto.c:      fatal_error ("Cannot read %s", file_data->file_name);

except fortran, which seems to not follow the general rule.

Patch

--- gcc/cgraphunit.c.jj	2012-02-12 15:46:32.000000000 +0100
+++ gcc/cgraphunit.c	2012-02-15 21:29:25.927382754 +0100
@@ -667,7 +667,7 @@  verify_cgraph_node (struct cgraph_node *
       for (i = 0; ipa_ref_list_reference_iterate (&node->ref_list, i, ref); i++)
 	if (ref->use != IPA_REF_ALIAS)
 	  {
-	    error ("Alias has non-alias refernece");
+	    error ("Alias has non-alias reference");
 	    error_found = true;
 	  }
 	else if (ref_found)