From patchwork Wed Feb 15 15:13:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 141403 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 94286100830 for ; Thu, 16 Feb 2012 07:33:27 +1100 (EST) Received: from localhost ([::1]:53233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxgYA-00045R-NE for incoming@patchwork.ozlabs.org; Wed, 15 Feb 2012 10:13:42 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxgXy-00044W-0M for qemu-devel@nongnu.org; Wed, 15 Feb 2012 10:13:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxgXs-0006Hl-Am for qemu-devel@nongnu.org; Wed, 15 Feb 2012 10:13:29 -0500 Received: from mail-qw0-f52.google.com ([209.85.216.52]:35160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxgXs-0006Hd-4k for qemu-devel@nongnu.org; Wed, 15 Feb 2012 10:13:24 -0500 Received: by qafi31 with SMTP id i31so1097590qaf.4 for ; Wed, 15 Feb 2012 07:13:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.134.196 with SMTP id k4mr15575986qct.29.1329318803203; Wed, 15 Feb 2012 07:13:23 -0800 (PST) Received: by 10.229.35.1 with HTTP; Wed, 15 Feb 2012 07:13:23 -0800 (PST) In-Reply-To: <1329316588-10830-7-git-send-email-peter.maydell@linaro.org> References: <1329316588-10830-1-git-send-email-peter.maydell@linaro.org> <1329316588-10830-7-git-send-email-peter.maydell@linaro.org> Date: Wed, 15 Feb 2012 15:13:23 +0000 Message-ID: From: Peter Maydell To: qemu-devel@nongnu.org X-Gm-Message-State: ALoCoQlrdBd+GZGomVWRPHUgtSdjfrqw8cx8nCha5mSOq4rK85BXzq/GDYIkxp1qTXWA2udB+OMz X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.216.52 Cc: Paul Brook , =?UTF-8?Q?Andreas_F=C3=A4rber?= , patches@linaro.org Subject: Re: [Qemu-devel] [PATCH v5 6/7] arm_boot: Pass base address of GIC CPU interface, not whole GIC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 15 February 2012 14:36, Peter Maydell wrote: > The arm_boot secondary boot loader code needs the address of > the GIC CPU interface. Obtaining this from the base address > of the private peripheral region was possible for A9 and 11MPcore, > but the A15 puts the GIC CPU interface in a different place. > So make boards pass in the GIC CPU interface address directly. > > Signed-off-by: Peter Maydell Post-exynos4-landing this is going to need an extra hunk: I'm not going to rebroadcast the patchset for this minor rebase fixup, unless anybody specifically wants me to... -- PMM diff --git a/hw/exynos4_boards.c b/hw/exynos4_boards.c index 329efbe..553a02b 100644 --- a/hw/exynos4_boards.c +++ b/hw/exynos4_boards.c @@ -112,7 +112,8 @@ static Exynos4210State *exynos4_boards_init_common( exynos4_board_binfo.kernel_filename = kernel_filename; exynos4_board_binfo.initrd_filename = initrd_filename; exynos4_board_binfo.kernel_cmdline = kernel_cmdline; - exynos4_board_binfo.smp_priv_base = EXYNOS4210_SMP_PRIVATE_BASE_ADDR; + exynos4_board_binfo.gic_cpu_if_addr = + EXYNOS4210_SMP_PRIVATE_BASE_ADDR + 0x100; PRINT_DEBUG("\n ram_size: %luMiB [0x%08lx]\n" " kernel_filename: %s\n"