From patchwork Wed Feb 15 10:18:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [RESEND,v2,3/3] ata: runtime suspend port if no device attached Date: Wed, 15 Feb 2012 00:18:52 -0000 From: Lin Ming X-Patchwork-Id: 141288 Message-Id: <1329301132-3687-4-git-send-email-ming.m.lin@intel.com> To: Jeff Garzik , "Rafael J. Wysocki" , Tejun Heo Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-pm@vger.kernel.org Add a new function ata_device_probed(...) to check if device was probed. Runtime suspend scsi_host--->ata port if no device was probed. Controller will be runtime suspended if all port were suspended already. Signed-off-by: Lin Ming --- drivers/ata/libata-core.c | 21 ++++++++++++++++++++- 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index c04ad68..1ff921b 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5906,6 +5906,21 @@ int ata_port_probe(struct ata_port *ap) return rc; } +/** + * ata_device_probed - Check if device is probed + * @ap: port to check + */ +static bool ata_device_probed(struct ata_port *ap) +{ + struct ata_link *link; + struct ata_device *dev; + + ata_for_each_link(link, ap, EDGE) + ata_for_each_dev(dev, link, ENABLED) + return true; + + return false; +} static void async_port_probe(void *data, async_cookie_t cookie) { @@ -5926,7 +5941,11 @@ static void async_port_probe(void *data, async_cookie_t cookie) /* in order to keep device order, we need to synchronize at this point */ async_synchronize_cookie(cookie); - ata_scsi_scan_host(ap, 1); + if (ata_device_probed(ap)) + ata_scsi_scan_host(ap, 1); + else + /* Runtime suspend it if no device is attached */ + pm_runtime_idle(&ap->scsi_host->shost_gendev); } /**