Patchwork UBUNTU: [Config] enable all LIRC modules

login
register
mail settings
Submitter Paolo Pisati
Date Feb. 14, 2012, 1:41 p.m.
Message ID <1329226878-12335-2-git-send-email-paolo.pisati@canonical.com>
Download mbox | patch
Permalink /patch/141112/
State New
Headers show

Comments

Paolo Pisati - Feb. 14, 2012, 1:41 p.m.
BugLink: http://bugs.launchpad.net/bugs/927526

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
---
 debian.ti-omap4/config/config.common.ubuntu |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)
Tim Gardner - Feb. 14, 2012, 3:10 p.m.
On 02/14/2012 06:41 AM, Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/927526
>
> Signed-off-by: Paolo Pisati<paolo.pisati@canonical.com>
> ---
>   debian.ti-omap4/config/config.common.ubuntu |   11 ++++++++++-
>   1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
> index d43c403..d4048e1 100644
> --- a/debian.ti-omap4/config/config.common.ubuntu
> +++ b/debian.ti-omap4/config/config.common.ubuntu
> @@ -1519,7 +1519,16 @@ CONFIG_LIBERTAS_USB=m
>   # CONFIG_LIBFCOE is not set
>   # CONFIG_LINE6_USB is not set
>   CONFIG_LIRC=y
> -# CONFIG_LIRC_STAGING is not set
> +CONFIG_LIRC_IGORPLUGUSB=m
> +CONFIG_LIRC_IMON=m
> +CONFIG_LIRC_PARALLEL=m
> +CONFIG_LIRC_SASEM=m
> +CONFIG_LIRC_SERIAL=m
> +CONFIG_LIRC_SERIAL_TRANSMITTER=y
> +CONFIG_LIRC_SIR=m
> +CONFIG_LIRC_STAGING=y
> +CONFIG_LIRC_TTUSBIR=m
> +CONFIG_LIRC_ZILOG=m
>   # CONFIG_LIS3L02DQ is not set
>   CONFIG_LITELINK_DONGLE=m
>   # CONFIG_LKDTM is not set
Herton Ronaldo Krzesinski - Feb. 14, 2012, 3:25 p.m.
On Tue, Feb 14, 2012 at 02:41:18PM +0100, Paolo Pisati wrote:
> BugLink: http://bugs.launchpad.net/bugs/927526
> 
> Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
> ---
>  debian.ti-omap4/config/config.common.ubuntu |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
> index d43c403..d4048e1 100644
> --- a/debian.ti-omap4/config/config.common.ubuntu
> +++ b/debian.ti-omap4/config/config.common.ubuntu
> @@ -1519,7 +1519,16 @@ CONFIG_LIBERTAS_USB=m
>  # CONFIG_LIBFCOE is not set
>  # CONFIG_LINE6_USB is not set
>  CONFIG_LIRC=y
> -# CONFIG_LIRC_STAGING is not set
> +CONFIG_LIRC_IGORPLUGUSB=m
> +CONFIG_LIRC_IMON=m
> +CONFIG_LIRC_PARALLEL=m
> +CONFIG_LIRC_SASEM=m
> +CONFIG_LIRC_SERIAL=m
> +CONFIG_LIRC_SERIAL_TRANSMITTER=y
> +CONFIG_LIRC_SIR=m
> +CONFIG_LIRC_STAGING=y
> +CONFIG_LIRC_TTUSBIR=m
> +CONFIG_LIRC_ZILOG=m
>  # CONFIG_LIS3L02DQ is not set
>  CONFIG_LITELINK_DONGLE=m
>  # CONFIG_LKDTM is not set
> -- 
> 1.7.9
> 

Ack on this patch.

But where are the other changes? ti-omap4 also needs IR_MCEUSB=m and
RC_CORE=m (=> LIRC=m) reading the bug report (and some others from the
git diff links posted). Also these changes aligns with what we have in
oneiric master.

> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Paolo Pisati - Feb. 14, 2012, 3:51 p.m.
On 02/14/2012 04:25 PM, Herton Ronaldo Krzesinski wrote:
>
> But where are the other changes? ti-omap4 also needs IR_MCEUSB=m and
> RC_CORE=m (=>  LIRC=m) reading the bug report (and some others from the
> git diff links posted). Also these changes aligns with what we have in
> oneiric master.

IR_MCEUSB is indeed missing, but the others are already compiled in and 
i didn't want to break POLA.

Patch

diff --git a/debian.ti-omap4/config/config.common.ubuntu b/debian.ti-omap4/config/config.common.ubuntu
index d43c403..d4048e1 100644
--- a/debian.ti-omap4/config/config.common.ubuntu
+++ b/debian.ti-omap4/config/config.common.ubuntu
@@ -1519,7 +1519,16 @@  CONFIG_LIBERTAS_USB=m
 # CONFIG_LIBFCOE is not set
 # CONFIG_LINE6_USB is not set
 CONFIG_LIRC=y
-# CONFIG_LIRC_STAGING is not set
+CONFIG_LIRC_IGORPLUGUSB=m
+CONFIG_LIRC_IMON=m
+CONFIG_LIRC_PARALLEL=m
+CONFIG_LIRC_SASEM=m
+CONFIG_LIRC_SERIAL=m
+CONFIG_LIRC_SERIAL_TRANSMITTER=y
+CONFIG_LIRC_SIR=m
+CONFIG_LIRC_STAGING=y
+CONFIG_LIRC_TTUSBIR=m
+CONFIG_LIRC_ZILOG=m
 # CONFIG_LIS3L02DQ is not set
 CONFIG_LITELINK_DONGLE=m
 # CONFIG_LKDTM is not set