Patchwork [go] : Disable TestListenMulticastUDP on alpha linux

login
register
mail settings
Submitter Uros Bizjak
Date Feb. 13, 2012, 7:59 p.m.
Message ID <CAFULd4an_Hd9OkqPRNKr-s-xgtmq=gVVHKhuxCocyjOpqB+nVw@mail.gmail.com>
Download mbox | patch
Permalink /patch/140968/
State New
Headers show

Comments

Uros Bizjak - Feb. 13, 2012, 7:59 p.m.
Hello!

alpha linux does not have expected "/proc/net/igmp" and
"/proc/net/igmp6" files, so "func interfaceMulticastAddrTable(ifindex
int)" from interface_linux.go always returns (nil, nil), failing
net/test with:

--- FAIL: net.TestListenMulticastUDP (4.71 seconds)
        ???:1: IPv4 multicast interface: <nil>
        ???:1: IPv4 multicast TTL: 1
        ???:1: IPv4 multicast loopback: false
        ???:1: "224.0.0.254:12345" not found in RIB
FAIL

Attached patch skips this sub-test in the same way as for ARM arch.

Tested on alphaev6-pc-linux-gnu, where it "fixes" failing net test.

Uros.
Ian Taylor - Feb. 14, 2012, 12:30 a.m.
Uros Bizjak <ubizjak@gmail.com> writes:

> alpha linux does not have expected "/proc/net/igmp" and
> "/proc/net/igmp6" files, so "func interfaceMulticastAddrTable(ifindex
> int)" from interface_linux.go always returns (nil, nil), failing
> net/test with:
>
> --- FAIL: net.TestListenMulticastUDP (4.71 seconds)
>         ???:1: IPv4 multicast interface: <nil>
>         ???:1: IPv4 multicast TTL: 1
>         ???:1: IPv4 multicast loopback: false
>         ???:1: "224.0.0.254:12345" not found in RIB
> FAIL
>
> Attached patch skips this sub-test in the same way as for ARM arch.
>
> Tested on alphaev6-pc-linux-gnu, where it "fixes" failing net test.

Thanks.

Committed.

Ian

Patch

Index: go/net/multicast_test.go
===================================================================
--- go/net/multicast_test.go	(revision 184156)
+++ go/net/multicast_test.go	(working copy)
@@ -33,7 +33,7 @@ 
 	case "netbsd", "openbsd", "plan9", "windows":
 		return
 	case "linux":
-		if runtime.GOARCH == "arm" {
+		if runtime.GOARCH == "arm" || runtime.GOARCH == "alpha" {
 			return
 		}
 	}