Patchwork [net-next] net_sched: sch_plug: plug_qdisc_ops is static

login
register
mail settings
Submitter Eric Dumazet
Date Feb. 13, 2012, 3:40 p.m.
Message ID <1329147645.2494.17.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Download mbox | patch
Permalink /patch/140919/
State Accepted
Delegated to: David Miller
Headers show

Comments

Eric Dumazet - Feb. 13, 2012, 3:40 p.m.
net/sched/sch_plug.c:211:18: warning: symbol 'plug_qdisc_ops' was not
declared. Should it be static?

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
 net/sched/sch_plug.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Feb. 13, 2012, 9:05 p.m.
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 13 Feb 2012 16:40:45 +0100

> net/sched/sch_plug.c:211:18: warning: symbol 'plug_qdisc_ops' was not
> declared. Should it be static?
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/sched/sch_plug.c b/net/sched/sch_plug.c
index ba7b737..89f8fcf 100644
--- a/net/sched/sch_plug.c
+++ b/net/sched/sch_plug.c
@@ -208,7 +208,7 @@  static int plug_change(struct Qdisc *sch, struct nlattr *opt)
 	return 0;
 }
 
-struct Qdisc_ops plug_qdisc_ops = {
+static struct Qdisc_ops plug_qdisc_ops __read_mostly = {
 	.id          =       "plug",
 	.priv_size   =       sizeof(struct plug_sched_data),
 	.enqueue     =       plug_enqueue,