Patchwork [1/2,v3] powerpc/85xx: Add Quicc Engine support for p1025rdb

From: Zhicheng Fan <b32736@freescale.com>

Signed-off-by: Zhicheng Fan <b32736@freescale.com>
---
 arch/powerpc/platforms/85xx/mpc85xx_rdb.c |   78 ++++++++++++++++++++++++++++-
 1 files changed, 77 insertions(+), 1 deletions(-)

On Sun, Feb 12, 2012 at 11:33 PM, Zhicheng Fan <B32736@freescale.com> wrote:
> From: Zhicheng Fan <b32736@freescale.com>
>
> Signed-off-by: Zhicheng Fan <b32736@freescale.com>
> ---
>  arch/powerpc/platforms/85xx/mpc85xx_rdb.c |   78 ++++++++++++++++++++++++++++-
>  1 files changed, 77 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> index e95aef7..c9dfdcc 100644
> --- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> +++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> @@ -26,6 +26,9 @@
>  #include <asm/prom.h>
>  #include <asm/udbg.h>
>  #include <asm/mpic.h>
> +#include <asm/qe.h>
> +#include <asm/qe_ic.h>
> +#include <asm/fsl_guts.h>
>
>  #include <sysdev/fsl_soc.h>
>  #include <sysdev/fsl_pci.h>
> @@ -47,6 +50,10 @@ void __init mpc85xx_rdb_pic_init(void)
>        struct mpic *mpic;
>        unsigned long root = of_get_flat_dt_root();
>
> +#ifdef CONFIG_QUICC_ENGINE
> +       struct device_node *np;
> +#endif
> +
>        if (of_flat_dt_is_compatible(root, "fsl,MPC85XXRDB-CAMP")) {
>                mpic = mpic_alloc(NULL, 0,
>                        MPIC_BIG_ENDIAN | MPIC_BROKEN_FRR_NIRQS |
> @@ -62,6 +69,18 @@ void __init mpc85xx_rdb_pic_init(void)
>
>        BUG_ON(mpic == NULL);
>        mpic_init(mpic);
> +
> +#ifdef CONFIG_QUICC_ENGINE
> +       np = of_find_compatible_node(NULL, NULL, "fsl,qe-ic");
> +       if (np) {
> +               qe_ic_init(np, 0, qe_ic_cascade_low_mpic,
> +                               qe_ic_cascade_high_mpic);
> +               of_node_put(np);
> +
> +       } else
> +               pr_err("%s: Could not find qe-ic node\n", __func__);
> +#endif
> +
>  }
>
>  /*
> @@ -69,7 +88,7 @@ void __init mpc85xx_rdb_pic_init(void)
>  */
>  static void __init mpc85xx_rdb_setup_arch(void)
>  {
> -#ifdef CONFIG_PCI
> +#if defined(CONFIG_PCI) || defined(CONFIG_QUICC_ENGINE)
>        struct device_node *np;
>  #endif
>
> @@ -85,6 +104,63 @@ static void __init mpc85xx_rdb_setup_arch(void)
>  #endif
>
>        mpc85xx_smp_init();
> +
> +#ifdef CONFIG_QUICC_ENGINE
> +       np = of_find_compatible_node(NULL, NULL, "fsl,qe");
> +       if (!np) {
> +               pr_err("%s: Could not find Quicc Engine node\n", __func__);
> +               goto qe_fail;
> +       }
> +
> +       qe_reset();
> +       of_node_put(np);
> +
> +       np = of_find_node_by_name(NULL, "par_io");
> +       if (np) {
> +               struct device_node *ucc;
> +
> +               par_io_init(np);
> +               of_node_put(np);
> +
> +               for_each_node_by_name(ucc, "ucc")
> +                       par_io_of_config(ucc);
> +
> +       }
> +       if (machine_is(p1025_rdb)) {
> +
> +               struct ccsr_guts_85xx __iomem *guts;
> +
> +               np = of_find_node_by_name(NULL, "global-utilities");
> +               if (np) {
> +
> +                       guts = of_iomap(np, 0);
> +                       if (!guts) {
> +
> +                               pr_err("mpc85xx-rdb: could not map global utilties register!\n");
> +
> +                       } else {
> +#if defined(CONFIG_UCC_GETH) || defined(CONFIG_SERIAL_QE)

This #if should be above the " if (machine_is(p1025_rdb)) {" line.

> +                       /* P1025 has pins muxed for QE and other functions. To
> +                       * enable QE UEC mode, we need to set bit QE0 for UCC1
> +                       * in Eth mode, QE0 and QE3 for UCC5 in Eth mode, QE9
> +                       * and QE12 for QE MII management singals in PMUXCR
> +                       * register.
> +                       */
> +                               setbits32(&guts->pmuxcr, MPC85xx_PMUXCR_QE0 |
> +                                               MPC85xx_PMUXCR_QE3 |
> +                                               MPC85xx_PMUXCR_QE9 |
> +                                               MPC85xx_PMUXCR_QE12);
> +#endif
> +                       }
> +                       iounmap(guts);

Put the iounmap() call inside the "else" bracket:


                               setbits32(&guts->pmuxcr, MPC85xx_PMUXCR_QE0 |
                                               MPC85xx_PMUXCR_QE3 |
                                               MPC85xx_PMUXCR_QE9 |
                                               MPC85xx_PMUXCR_QE12);
                               iounmap(guts);
                       }

You're not really paying attention to the code that you're writing.
Please take a good look at your code before you paste it.