diff mbox

Go testsuite patch committed: Don't run nilptr on SPARC Solaris

Message ID mcr7gzsio7u.fsf@dhcp-172-18-216-180.mtv.corp.google.com
State New
Headers show

Commit Message

Ian Lance Taylor Feb. 12, 2012, 6:02 a.m. UTC 
The nilptr.go test fails on 64-bit SPARC Solaris systems, because the
linker puts the array in a place where the test can not work correctly.
I disabled it on all SPARC Solaris systems.  I changed to disabling to
not run the test, rather than to xfail it.  For this test, an XPASS is
not useful information.  Tested on sparc-sun-solaris2.11 and
x86_64-unknown-linux-gnu.  Committed to mainline.

Ian


2012-02-11  Ian Lance Taylor  <iant@google.com>

	PR go/51874
	* go.test/go-test.exp (go-gc-tests): Don't run nilptr test on
	SPARC Solaris.  Don't run the test at all on systems where it may
	not work, rather than xfailing it.
diff mbox

Patch

Index: gcc/testsuite/go.test/go-test.exp
===================================================================
--- gcc/testsuite/go.test/go-test.exp	(revision 184035)
+++ gcc/testsuite/go.test/go-test.exp	(working copy)
@@ -302,9 +302,9 @@  proc go-gc-tests { } {
 	}
 
 	# Handle certain tests in a target-dependant way.
-	if [istarget "alpha*-*-*"] {
+	if { [istarget "alpha*-*-*"] || [istarget "sparc*-*-solaris*"] } {
 	    if { [string match "*go.test/test/nilptr.go" $test] } {
-		go-execute-xfail $test
+		untested $test
 		continue
 	    }
 	}