Patchwork libgo patch committed: Disable inappropriate sync/atomic tests

login
register
mail settings
Submitter Ian Taylor
Date Feb. 12, 2012, 5:57 a.m.
Message ID <mcrbop4ioge.fsf@dhcp-172-18-216-180.mtv.corp.google.com>
Download mbox | patch
Permalink /patch/140799/
State New
Headers show

Comments

Ian Taylor - Feb. 12, 2012, 5:57 a.m.
This patch to the sync/atomic package disables a couple of tests on
systems with an inappropriate pointer size.  The 32-bit test was
clobbering 4 bytes on the heap.  The 64-bit test only worked on
little-endian systems.  Bootstrapped and ran Go testsuite on
x86_64-unknown-linux-gnu.  Committed to mainline.

Ian

Patch

diff -r d75f0efa5fc2 libgo/go/sync/atomic/atomic_test.go
--- a/libgo/go/sync/atomic/atomic_test.go	Fri Feb 10 23:04:22 2012 -0800
+++ b/libgo/go/sync/atomic/atomic_test.go	Sat Feb 11 21:54:35 2012 -0800
@@ -636,6 +636,7 @@ 
 		// 64-bit system; clear uintptr tests
 		hammer32[2].f = nil
 		hammer32[5].f = nil
+		hammer32[6].f = nil
 	}
 }
 
@@ -760,6 +761,7 @@ 
 		// 32-bit system; clear uintptr tests
 		hammer64[2].f = nil
 		hammer64[5].f = nil
+		hammer64[6].f = nil
 	}
 }