| Message ID | alpine.DEB.2.00.1202101606530.3840@router.home |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Fri, Feb 10, 2012 at 04:07:57PM -0600, Christoph Lameter wrote: > Proposal for a patch for slub to move the pfmemalloc handling out of the > fastpath by simply not assigning a per cpu slab when pfmemalloc processing > is going on. > > > > Subject: [slub] Fix so that no mods are required for the fast path > > Remove the check for pfmemalloc from the alloc hotpath and put the logic after > the election of a new per cpu slab. > > For a pfmemalloc page do not use the fast path but force use of the slow > path (which is also used for the debug case). > > Signed-off-by: Christoph Lameter <cl@linux.com> > This weakens pfmemalloc processing in the following way 1. Process that is performance network swap calls __slab_alloc. pfmemalloc_match is true so the freelist is loaded and c->freelist is now pointing to a pfmemalloc page 2. Process that is attempting normal allocations calls slab_alloc, finds the pfmemalloc page on the freelist and uses it because it did not check pfmemalloc_match() The patch allows non-pfmemalloc allocations to use pfmemalloc pages with the kmalloc slabs being the most vunerable caches on the grounds they are most likely to have a mix of pfmemalloc and !pfmemalloc requests. Patch 14 will still protect the system as processes will get throttled if the pfmemalloc reserves get depleted so performance will not degrade as smoothly. Assuming this passes testing, I'll add the patch to the series with the information above included in the changelog. Thanks Christoph.
Index: linux-2.6/mm/slub.c =================================================================== --- linux-2.6.orig/mm/slub.c 2012-02-10 09:58:13.066125970 -0600 +++ linux-2.6/mm/slub.c 2012-02-10 10:06:07.114113000 -0600 @@ -2273,11 +2273,12 @@ new_slab: } } - if (likely(!kmem_cache_debug(s))) + if (likely(!kmem_cache_debug(s) && pfmemalloc_match(c, gfpflags))) goto load_freelist; + /* Only entered in the debug case */ - if (!alloc_debug_processing(s, c->page, object, addr)) + if (kmem_cache_debug(s) && !alloc_debug_processing(s, c->page, object, addr)) goto new_slab; /* Slab failed checks. Next slab needed */ c->freelist = get_freepointer(s, object); @@ -2327,8 +2328,7 @@ redo: barrier(); object = c->freelist; - if (unlikely(!object || !node_match(c, node) || - !pfmemalloc_match(c, gfpflags))) + if (unlikely(!object || !node_match(c, node))) object = __slab_alloc(s, gfpflags, node, addr, c); else {
Proposal for a patch for slub to move the pfmemalloc handling out of the fastpath by simply not assigning a per cpu slab when pfmemalloc processing is going on. Subject: [slub] Fix so that no mods are required for the fast path Remove the check for pfmemalloc from the alloc hotpath and put the logic after the election of a new per cpu slab. For a pfmemalloc page do not use the fast path but force use of the slow path (which is also used for the debug case). Signed-off-by: Christoph Lameter <cl@linux.com> --- mm/slub.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html