Patchwork [v9,0/3] libsas error handling + discovery v9

login
register
mail settings
Submitter Dan Williams
Date Feb. 10, 2012, 9:52 p.m.
Message ID <20120210215220.17007.80540.stgit@dwillia2-linux.jf.intel.com>
Download mbox | patch
Permalink /patch/140722/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Dan Williams - Feb. 10, 2012, 9:52 p.m.
Changes since v8: http://marc.info/?l=linux-scsi&m=132886259501191&w=2

Noticed that the rebased version of "libsas: close scsi_remove_target()
vs libata-eh race" mistakenly dropped a necessary call to
sas_put_device().

...reflowed the other two patches as a result, and added Jeff Garzik's
acked-by:

[PATCH 1/3] libsas: close scsi_remove_target() vs libata-eh race
[PATCH 2/3] libsas: improve debug statements
[PATCH 3/3] libsas: async ata scanning

Incremental diff from v8:

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 1b1d4b7..bc0cecc 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -715,6 +715,7 @@  static void async_sas_ata_eh(void *data, async_cookie_t cookie)
 	kref_get(&dev->kref);
 	sas_ata_printk(KERN_DEBUG, dev, "dev error handler\n");
 	ata_scsi_port_error_handler(ha->core.shost, ap);
+	sas_put_device(dev);
 }
 
 static bool sas_ata_dev_eh_valid(struct domain_device *dev)