Patchwork fwts-collect: collect more fwts dumped data

login
register
mail settings
Submitter Colin King
Date Feb. 10, 2012, 3:34 p.m.
Message ID <1328888050-29057-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/140670/
State Accepted
Headers show

Comments

Colin King - Feb. 10, 2012, 3:34 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 doc/fwts-collect.1   |    4 ++--
 scripts/fwts-collect |    5 ++++-
 2 files changed, 6 insertions(+), 3 deletions(-)
Keng-Yu Lin - Feb. 21, 2012, 3:22 a.m.
On Fri, Feb 10, 2012 at 11:34 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  doc/fwts-collect.1   |    4 ++--
>  scripts/fwts-collect |    5 ++++-
>  2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/doc/fwts-collect.1 b/doc/fwts-collect.1
> index 613372f..3bec02f 100644
> --- a/doc/fwts-collect.1
> +++ b/doc/fwts-collect.1
> @@ -34,8 +34,8 @@ collects logs and various system and firmware dumps into the gzip'd tar ball
>  fwts-logs.tar.gz which can then be added to bug reports.  It collects data
>  from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from
>  /sys/firmware/acpi/interrupts and kernel logs.  It also invokes fwts and
> -gathers ACPI tables, memorymaps, MultiProcessor table dumps, kernel version
> -and ACPI version information.
> +gathers ACPI tables, memorymaps, MultiProcessor table dumps, CMOS data,
> +UEFI variables, EBDA region, kernel version and ACPI version information.
>  .B
>  fwts
>  using sudo is required.
> diff --git a/scripts/fwts-collect b/scripts/fwts-collect
> index fddc071..f8bd12c 100755
> --- a/scripts/fwts-collect
> +++ b/scripts/fwts-collect
> @@ -142,7 +142,10 @@ cp /var/log/kern.log kern.log
>  #
>  #  fwts specific output
>  #
> -sudo fwts --dump >& /dev/null
> +fwts --dump >& /dev/null
> +fwts cmosdump --log-format="" -r cmosdump.log >& /dev/null
> +fwts ebdadump --log-format="" -r ebdadump.log >& /dev/null
> +fwts uefidump --log-format="" -r uefidump.log >& /dev/null
>  fwts memmapdump --log-format="" -r memmap.log >& /dev/null
>  fwts acpidump --log-format="" -r acpitables.log >& /dev/null
>  fwts mpdump --log-format="" -r mpdump.log >& /dev/null
> --
> 1.7.9
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Chris Van Hoof - March 1, 2012, 8:32 p.m.
On 02/10/2012 10:34 AM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   doc/fwts-collect.1   |    4 ++--
>   scripts/fwts-collect |    5 ++++-
>   2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/doc/fwts-collect.1 b/doc/fwts-collect.1
> index 613372f..3bec02f 100644
> --- a/doc/fwts-collect.1
> +++ b/doc/fwts-collect.1
> @@ -34,8 +34,8 @@ collects logs and various system and firmware dumps into the gzip'd tar ball
>   fwts-logs.tar.gz which can then be added to bug reports.  It collects data
>   from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from
>   /sys/firmware/acpi/interrupts and kernel logs.  It also invokes fwts and
> -gathers ACPI tables, memorymaps, MultiProcessor table dumps, kernel version
> -and ACPI version information.
> +gathers ACPI tables, memorymaps, MultiProcessor table dumps, CMOS data,
> +UEFI variables, EBDA region, kernel version and ACPI version information.
>   .B
>   fwts
>   using sudo is required.
> diff --git a/scripts/fwts-collect b/scripts/fwts-collect
> index fddc071..f8bd12c 100755
> --- a/scripts/fwts-collect
> +++ b/scripts/fwts-collect
> @@ -142,7 +142,10 @@ cp /var/log/kern.log kern.log
>   #
>   #  fwts specific output
>   #
> -sudo fwts --dump>&  /dev/null
> +fwts --dump>&  /dev/null
> +fwts cmosdump --log-format="" -r cmosdump.log>&  /dev/null
> +fwts ebdadump --log-format="" -r ebdadump.log>&  /dev/null
> +fwts uefidump --log-format="" -r uefidump.log>&  /dev/null
>   fwts memmapdump --log-format="" -r memmap.log>&  /dev/null
>   fwts acpidump --log-format="" -r acpitables.log>&  /dev/null
>   fwts mpdump --log-format="" -r mpdump.log>&  /dev/null

This was used in the fwts-live images last week at Plugfest and 
fwts-collect works as expected:

Acked-by: Chris Van Hoof <vanhoof@canonical.com>

Patch

diff --git a/doc/fwts-collect.1 b/doc/fwts-collect.1
index 613372f..3bec02f 100644
--- a/doc/fwts-collect.1
+++ b/doc/fwts-collect.1
@@ -34,8 +34,8 @@  collects logs and various system and firmware dumps into the gzip'd tar ball
 fwts-logs.tar.gz which can then be added to bug reports.  It collects data
 from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from 
 /sys/firmware/acpi/interrupts and kernel logs.  It also invokes fwts and
-gathers ACPI tables, memorymaps, MultiProcessor table dumps, kernel version
-and ACPI version information. 
+gathers ACPI tables, memorymaps, MultiProcessor table dumps, CMOS data,
+UEFI variables, EBDA region, kernel version and ACPI version information. 
 .B
 fwts
 using sudo is required.
diff --git a/scripts/fwts-collect b/scripts/fwts-collect
index fddc071..f8bd12c 100755
--- a/scripts/fwts-collect
+++ b/scripts/fwts-collect
@@ -142,7 +142,10 @@  cp /var/log/kern.log kern.log
 #
 #  fwts specific output
 #
-sudo fwts --dump >& /dev/null
+fwts --dump >& /dev/null
+fwts cmosdump --log-format="" -r cmosdump.log >& /dev/null
+fwts ebdadump --log-format="" -r ebdadump.log >& /dev/null
+fwts uefidump --log-format="" -r uefidump.log >& /dev/null
 fwts memmapdump --log-format="" -r memmap.log >& /dev/null
 fwts acpidump --log-format="" -r acpitables.log >& /dev/null
 fwts mpdump --log-format="" -r mpdump.log >& /dev/null