From patchwork Mon Dec 15 13:35:21 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarek Poplawski X-Patchwork-Id: 14054 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id BF17ADDF6C for ; Tue, 16 Dec 2008 00:35:39 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbYLONfa (ORCPT ); Mon, 15 Dec 2008 08:35:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752625AbYLONf2 (ORCPT ); Mon, 15 Dec 2008 08:35:28 -0500 Received: from mail-ew0-f17.google.com ([209.85.219.17]:39239 "EHLO mail-ew0-f17.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbYLONf1 (ORCPT ); Mon, 15 Dec 2008 08:35:27 -0500 Received: by ewy10 with SMTP id 10so3022155ewy.13 for ; Mon, 15 Dec 2008 05:35:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=fC7hg2WXgGuX6m5z4HslAML7fLsE4wOS+4e68sbPw34=; b=JLiljbzMeal1h490ucflOtI+qDJ/VvsbeGROUb4eyNd62aIVEhf03b/YJm1AYgbqjL 62a8CvclzzR5fS1ze1CohPYm3JHptGIlNpv7qLl1BDLVmS1nu/XghqvRFmw5vXHKdoVy F94wn/1HCwME6D7R5VqrByoXr8uzktisBK18k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:in-reply-to:user-agent; b=qS5A+3DjTzUfD2qP/4ADZL5GR7spRUfYs8+KgAaeiiV6E36BQXKqJZtKp2HTADZyal JVUZXE7c3QZ9NXbXZosnEbztbIDIiPSwULJWQVgHSk2Z+IA6N79VZnmgok6mvMmlrIPB JPcvuHR5w0BBiUn7JWZwTCiWQcFpAEo7IGx5U= Received: by 10.210.90.10 with SMTP id n10mr4469071ebb.160.1229348125829; Mon, 15 Dec 2008 05:35:25 -0800 (PST) Received: from ff.dom.local (bv170.internetdsl.tpnet.pl [80.53.205.170]) by mx.google.com with ESMTPS id f6sm13529533nfh.29.2008.12.15.05.35.24 (version=SSLv3 cipher=RC4-MD5); Mon, 15 Dec 2008 05:35:25 -0800 (PST) Date: Mon, 15 Dec 2008 13:35:21 +0000 From: Jarek Poplawski To: David Miller Cc: alexander.huemer@sbg.ac.at, linux-net@vger.kernel.org, netdev@vger.kernel.org Subject: Re: kernel panics with net_rx_action on kernels >2.6.26 Message-ID: <20081215133521.GA6697@ff.dom.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20081214.224800.125614949.davem@davemloft.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 15-12-2008 07:48, David Miller wrote: > From: Alexander Huemer > Date: Sun, 14 Dec 2008 15:17:32 +0100 > > Networking developers generally don't read the linux-net list, it is > for user configuration and basic questions only, not bug reports or > technical discussions. > > netdev is the place to report such things, and I've added that to the > CC: > >> one of my machines (x86) crashes under heavy network load with kernels >>> 2.6.26, i tried quite everything possible between 2.6.27 and 2.6.28-rc8. >> lspci -vv: http://xx.vu/~ahuemer/lspci_vv.txt >> of the quad nic 2 ports are used, the machine is acting as a iptables >> firewall/router. >> >> kernel config (2.6.26) http://xx.vu/~ahuemer/config >> screenshot of the panic: >> http://xx.vu/~ahuemer/kernel_panic_net_rx_action.jpg >> >> as i do not have any problems with kernels <=2.6.26, i doubt that this >> is a hardware problem. >> in case of the panic, nothing is written to the system log. >> >> any hints welcome. >> please CC me on replies, i am not subscribed to the mailing list. Could you try this patch, please? Jarek P. --- drivers/net/starfire.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/starfire.c b/drivers/net/starfire.c index 0358809..f86d6bb 100644 --- a/drivers/net/starfire.c +++ b/drivers/net/starfire.c @@ -1503,6 +1503,11 @@ static int __netdev_rx(struct net_device *dev, int *quota) desc->status = 0; np->rx_done = (np->rx_done + 1) % DONE_Q_SIZE; } + + if (*quota == 0) { /* out of rx quota */ + retcode = 1; + goto out; + } writew(np->rx_done, np->base + CompletionQConsumerIdx); out: