Message ID | 4F31BE47.2020506@ubuntu.com |
---|---|
State | New |
Headers | show |
On Wed, 8 Feb 2012, Matthias Klose wrote: > there is one more issue, when configuring > > --with-sysroot=/ --with-gxx-include-dir=/usr/include/c++/4.7 > > in that the leading / is stripped away in configure.ac. This case needs an > explicit check. Ok for the trunk? This looks like a case where any sysroot with a trailing '/' could misbehave and remove a leading '/' that should be left there, i.e. where gcc_gxx_without_sysroot should be computed in a way that ignores any trailing '/' on the sysroot setting. Or is such a removal actually harmless in all cases except for plain '/' as the sysroot?
--- a/src/gcc/configure.ac +++ b/src/gcc/configure.ac @@ -149,7 +149,9 @@ if test "${with_sysroot+set}" = set; then gcc_gxx_without_sysroot=`expr "${gcc_gxx_include_dir}" : "${with_sysroot}"'\(.*\)'` if test "${gcc_gxx_without_sysroot}"; then - gcc_gxx_include_dir="${gcc_gxx_without_sysroot}" + if test x${with_sysroot} != x/; then + gcc_gxx_include_dir="${gcc_gxx_without_sysroot}" + fi gcc_gxx_include_dir_add_sysroot=1 fi fi