From patchwork Mon Dec 15 11:13:08 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarek Poplawski X-Patchwork-Id: 14004 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 4FF51DDF9B for ; Mon, 15 Dec 2008 22:13:22 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753673AbYLOLNT (ORCPT ); Mon, 15 Dec 2008 06:13:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753603AbYLOLNS (ORCPT ); Mon, 15 Dec 2008 06:13:18 -0500 Received: from ug-out-1314.google.com ([66.249.92.174]:7352 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753419AbYLOLNR (ORCPT ); Mon, 15 Dec 2008 06:13:17 -0500 Received: by ug-out-1314.google.com with SMTP id 39so166685ugf.37 for ; Mon, 15 Dec 2008 03:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=DP/HHgyiBOCoaimxV/Zy+9Y+84AaQEDTWyf/r84NVbw=; b=gZbppd89LUolPR2ioVWeGfM7lhg4dQEi9myAKCB9kBEur2ORp59H9VMRxdyFiqf1IY Zn8gAFx00vE4ZlXvlh6QJjiL/ahTLW8Kq9Uk5gTEIkE7bhXSCjbPqr5o+EES3jn1SiG7 J+SsRw70d3OetfBU1gfTCZoUaZOsRreZ7WVa8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=N1AunOtmMn0PkJGO3RUgajehmgcqvBhJPQxP9/bkhY+ZCgmAMFsut9wFx8Indc1RkN T+L1Md3CV8zeGKky5/zvgkqSF9sJXdR2CQcOX7NUHvW/YnJpPQGNGSp2UkW3SqerzmCn QM8vn5OIcoOH/2vg7pxEgu96kH3tASf/VwQW0= Received: by 10.67.116.8 with SMTP id t8mr1776922ugm.53.1229339595590; Mon, 15 Dec 2008 03:13:15 -0800 (PST) Received: from ff.dom.local (bv170.internetdsl.tpnet.pl [80.53.205.170]) by mx.google.com with ESMTPS id 24sm157384ugf.22.2008.12.15.03.13.12 (version=SSLv3 cipher=RC4-MD5); Mon, 15 Dec 2008 03:13:12 -0800 (PST) Date: Mon, 15 Dec 2008 11:13:08 +0000 From: Jarek Poplawski To: Badalian Vyacheslav Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: deadlocks if use htb Message-ID: <20081215111308.GA5853@ff.dom.local> References: <20081010075640.GA5204@ff.dom.local> <48EF17EA.5020306@bigtelecom.ru> <20081010090426.GA6054@ff.dom.local> <20081010095129.GB6054@ff.dom.local> <48F6FB3E.7060903@bigtelecom.ru> <20081016084027.GA17632@ff.dom.local> <48FEC302.5090707@bigtelecom.ru> <20081022070200.GB4178@ff.dom.local> <493FDCD4.5020108@bigtelecom.ru> <20081211084606.GA4129@ff.dom.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20081211084606.GA4129@ff.dom.local> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Dec 11, 2008 at 08:46:06AM +0000, Jarek Poplawski wrote: > On Wed, Dec 10, 2008 at 06:14:28PM +0300, Badalian Vyacheslav wrote: > > Hello again! Sorry for long away. > > Hi! > > > I was go away from this work for long time. > > > > May we return to this bug? > > Servers at last stable kernel 2.6.27.8 > > HZ=1000, HR=off, DynamicTicks=off, hysteresis=1 > > Sorry - no patched, update do not i. Do you have fresh patches or ideas > > for tests? > > Not much, but I can have if you only are willing to test them... > I attach below a patch which combines 2 patches I sent yesterday to > netdev (PATCH 7/6 and 8/6) vs. 2.6.27.7 (named testing patch #3 here). > > You can still try the testing patch #2 I sent previously (quoted below) > with or without this new #3 patch. > Here is another idea worth checking (instead of patch #2). Jarek P. --- (testing patch #4) --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -Nurp a2.6.27.7/net/sched/sch_htb.c b2.6.27.7/net/sched/sch_htb.c --- a2.6.27.7/net/sched/sch_htb.c 2008-12-11 08:16:16.000000000 +0000 +++ b2.6.27.7/net/sched/sch_htb.c 2008-12-15 10:44:32.000000000 +0000 @@ -924,6 +924,7 @@ static struct sk_buff *htb_dequeue(struc } } sch->qstats.overlimits++; + qdisc_watchdog_cancel(&q->watchdog); qdisc_watchdog_schedule(&q->watchdog, next_event); fin: return skb;