Patchwork pcie: aspm: use FWTS_ROOT_PRIV flag

login
register
mail settings
Submitter Alex Hung
Date Feb. 7, 2012, 10:39 a.m.
Message ID <1328611153-2755-1-git-send-email-alex.hung@canonical.com>
Download mbox | patch
Permalink /patch/139896/
State Accepted
Headers show

Comments

Alex Hung - Feb. 7, 2012, 10:39 a.m.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/pci/aspm/aspm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Colin King - Feb. 7, 2012, 11:51 a.m.
On 07/02/12 10:39, Alex Hung wrote:
> Signed-off-by: Alex Hung<alex.hung@canonical.com>
> ---
>   src/pci/aspm/aspm.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c
> index 0f062f5..db82718 100644
> --- a/src/pci/aspm/aspm.c
> +++ b/src/pci/aspm/aspm.c
> @@ -75,4 +75,4 @@ static fwts_framework_ops aspm_ops = {
>   	.minor_tests = aspm_tests
>   };
>
> -FWTS_REGISTER(aspm,&aspm_ops, FWTS_TEST_ANYTIME, FWTS_BATCH);
> +FWTS_REGISTER(aspm,&aspm_ops, FWTS_TEST_ANYTIME, FWTS_BATCH | FWTS_ROOT_PRIV);

Yep, that's required! Good find.

Acked-by: Colin King <colin.king@canonical.com>
Keng-Yu Lin - Feb. 8, 2012, 7:27 a.m.
On Tue, Feb 7, 2012 at 7:51 PM, Colin Ian King <colin.king@canonical.com> wrote:
> On 07/02/12 10:39, Alex Hung wrote:
>>
>> Signed-off-by: Alex Hung<alex.hung@canonical.com>
>> ---
>>  src/pci/aspm/aspm.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c
>> index 0f062f5..db82718 100644
>> --- a/src/pci/aspm/aspm.c
>> +++ b/src/pci/aspm/aspm.c
>> @@ -75,4 +75,4 @@ static fwts_framework_ops aspm_ops = {
>>        .minor_tests = aspm_tests
>>  };
>>
>> -FWTS_REGISTER(aspm,&aspm_ops, FWTS_TEST_ANYTIME, FWTS_BATCH);
>> +FWTS_REGISTER(aspm,&aspm_ops, FWTS_TEST_ANYTIME, FWTS_BATCH |
>> FWTS_ROOT_PRIV);
>
>
> Yep, that's required! Good find.
>
> Acked-by: Colin King <colin.king@canonical.com>
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/src/pci/aspm/aspm.c b/src/pci/aspm/aspm.c
index 0f062f5..db82718 100644
--- a/src/pci/aspm/aspm.c
+++ b/src/pci/aspm/aspm.c
@@ -75,4 +75,4 @@  static fwts_framework_ops aspm_ops = {
 	.minor_tests = aspm_tests
 };
 
-FWTS_REGISTER(aspm, &aspm_ops, FWTS_TEST_ANYTIME, FWTS_BATCH);
+FWTS_REGISTER(aspm, &aspm_ops, FWTS_TEST_ANYTIME, FWTS_BATCH | FWTS_ROOT_PRIV);