acer-wmi: support for P key on TM8372

Submitted by Ike Panhc on Feb. 6, 2012, 10:42 a.m.

Details

Message ID 1328524933-16571-1-git-send-email-ike.pan@canonical.com
State New
Headers show

Commit Message

Ike Panhc Feb. 6, 2012, 10:42 a.m.
From: Merlin Schumacher <merlin.schumacher@gmail.com>

BugLink: http://launchpad.net/bugs/865807

There is no entry for P key on TM8372, so when P key is pressed, only
"acer_wmi: Unknown key number - 0x29" in dmesg.

Signed-off-by: Merlin Schumacher <merlin.schumacher@gmail.com>
Signed-off-by: Ike Panhc <ike.pan@canonical.com>
---
 drivers/platform/x86/acer-wmi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Tim Gardner Feb. 6, 2012, 3:04 p.m.
On 02/06/2012 03:42 AM, Ike Panhc wrote:
> From: Merlin Schumacher<merlin.schumacher@gmail.com>
>
> BugLink: http://launchpad.net/bugs/865807
>
> There is no entry for P key on TM8372, so when P key is pressed, only
> "acer_wmi: Unknown key number - 0x29" in dmesg.
>
> Signed-off-by: Merlin Schumacher<merlin.schumacher@gmail.com>
> Signed-off-by: Ike Panhc<ike.pan@canonical.com>
> ---
>   drivers/platform/x86/acer-wmi.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 5957f62..d5ff8ac 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -105,6 +105,7 @@ static const struct key_entry acer_wmi_keymap[] = {
>   	{KE_KEY, 0x22, {KEY_PROG2} },    /* Arcade */
>   	{KE_KEY, 0x23, {KEY_PROG3} },    /* P_Key */
>   	{KE_KEY, 0x24, {KEY_PROG4} },    /* Social networking_Key */
> +	{KE_KEY, 0x29, {KEY_PROG3} },    /* P_Key for TM8372 */
>   	{KE_IGNORE, 0x41, {KEY_MUTE} },
>   	{KE_IGNORE, 0x42, {KEY_PREVIOUSSONG} },
>   	{KE_IGNORE, 0x43, {KEY_NEXTSONG} },

Applied as a SAUCE patch to Oneiric/Precise master-next.

I don't think these simple one line patches need to be held to a higher 
standard then those recently received, e.g., PCI ID's etc.

rtg
Stefan Bader Feb. 6, 2012, 3:58 p.m.
On 06.02.2012 16:04, Tim Gardner wrote:
> On 02/06/2012 03:42 AM, Ike Panhc wrote:
>> From: Merlin Schumacher<merlin.schumacher@gmail.com>
>>
>> BugLink: http://launchpad.net/bugs/865807
>>
>> There is no entry for P key on TM8372, so when P key is pressed, only
>> "acer_wmi: Unknown key number - 0x29" in dmesg.
>>
>> Signed-off-by: Merlin Schumacher<merlin.schumacher@gmail.com>
>> Signed-off-by: Ike Panhc<ike.pan@canonical.com>
>> ---
>>   drivers/platform/x86/acer-wmi.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> index 5957f62..d5ff8ac 100644
>> --- a/drivers/platform/x86/acer-wmi.c
>> +++ b/drivers/platform/x86/acer-wmi.c
>> @@ -105,6 +105,7 @@ static const struct key_entry acer_wmi_keymap[] = {
>>       {KE_KEY, 0x22, {KEY_PROG2} },    /* Arcade */
>>       {KE_KEY, 0x23, {KEY_PROG3} },    /* P_Key */
>>       {KE_KEY, 0x24, {KEY_PROG4} },    /* Social networking_Key */
>> +    {KE_KEY, 0x29, {KEY_PROG3} },    /* P_Key for TM8372 */
>>       {KE_IGNORE, 0x41, {KEY_MUTE} },
>>       {KE_IGNORE, 0x42, {KEY_PREVIOUSSONG} },
>>       {KE_IGNORE, 0x43, {KEY_NEXTSONG} },
> 
> Applied as a SAUCE patch to Oneiric/Precise master-next.
> 
> I don't think these simple one line patches need to be held to a higher standard
> then those recently received, e.g., PCI ID's etc.
> 
Hm, should not care that much, but for a released version a bug report for
tracking and verification should be a standard, even for those simple things.
And why messing around with sauce if you can educate people to just go via
upstream stable... Of course this won't work if people can go to dad when mom
said no... ;-P

-Stefan
> rtg

Patch hide | download patch | download mbox

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 5957f62..d5ff8ac 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -105,6 +105,7 @@  static const struct key_entry acer_wmi_keymap[] = {
 	{KE_KEY, 0x22, {KEY_PROG2} },    /* Arcade */
 	{KE_KEY, 0x23, {KEY_PROG3} },    /* P_Key */
 	{KE_KEY, 0x24, {KEY_PROG4} },    /* Social networking_Key */
+	{KE_KEY, 0x29, {KEY_PROG3} },    /* P_Key for TM8372 */
 	{KE_IGNORE, 0x41, {KEY_MUTE} },
 	{KE_IGNORE, 0x42, {KEY_PREVIOUSSONG} },
 	{KE_IGNORE, 0x43, {KEY_NEXTSONG} },