Patchwork document which edition of Effective C++ is used for -Weffc++

login
register
mail settings
Submitter Jonathan Wakely
Date Feb. 6, 2012, 12:37 a.m.
Message ID <CAH6eHdRLz0se8jevHppR-54acGCu4kBSL9NQAW6EiKXGhNc_wQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/139672/
State New
Headers show

Comments

Jonathan Wakely - Feb. 6, 2012, 12:37 a.m.
PR c++/48680
        * doc/invoke.texi (C++ Dialect Options): Use @option markup for
        -Weffc++ and specify guidelines come from second edition.

Tested with 'make doc html'
OK for trunk?
Gerald Pfeifer - Feb. 6, 2012, 1:04 a.m.
On Mon, 6 Feb 2012, Jonathan Wakely wrote:
>         PR c++/48680
>         * doc/invoke.texi (C++ Dialect Options): Use @option markup for
>         -Weffc++ and specify guidelines come from second edition.
> 
> Tested with 'make doc html'
> OK for trunk?

Yes.  The first is a bug fix, the second obvious (for those in
the know, before your patch :-).

Gerald
Jonathan Wakely - Feb. 6, 2012, 1:06 a.m.
On 6 February 2012 01:04, Gerald Pfeifer wrote:
> On Mon, 6 Feb 2012, Jonathan Wakely wrote:
>>         PR c++/48680
>>         * doc/invoke.texi (C++ Dialect Options): Use @option markup for
>>         -Weffc++ and specify guidelines come from second edition.
>>
>> Tested with 'make doc html'
>> OK for trunk?
>
> Yes.  The first is a bug fix, the second obvious (for those in
> the know, before your patch :-).

Thanks, I've checked it in.

Patch

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 6105710..6c61e53 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -2437,7 +2437,7 @@  the compiler to never throw an exception.
 Warn when a class has virtual functions and accessible non-virtual
 destructor, in which case it would be possible but unsafe to delete
 an instance of a derived class through a pointer to the base class.
-This warning is also enabled if -Weffc++ is specified.
+This warning is also enabled if @option{-Weffc++} is specified.
 
 @item -Wreorder @r{(C++ and Objective-C++ only)}
 @opindex Wreorder
@@ -2467,7 +2467,7 @@  The following @option{-W@dots{}} options are not affected by @option{-Wall}.
 @opindex Weffc++
 @opindex Wno-effc++
 Warn about violations of the following style guidelines from Scott Meyers'
-@cite{Effective C++} book:
+@cite{Effective C++, Second Edition} book:
 
 @itemize @bullet
 @item